Polish graph #395
Merged
Polish graph #395
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
add restore image add panning and zooming to graph
jetfuel
previously approved these changes
Apr 16, 2018
| }, | ||
| methods: { | ||
| restoreImage(thenDownload) { |
There was a problem hiding this comment.
I feel we should divide this into two functions.
restore Image and download images are not tightly related. But I understand if there is technical difficulties, we can leave them as it is for now.
Let's leave some more comments to explain this edge case. Should be helpful later.
|
|
||
| if (thenDownload) { | ||
| svg.transition() |
There was a problem hiding this comment.
Ah, I see. We can use this callback function to download the images. Nice.
daming-lu
commented
Apr 16, 2018
| @@ -52,7 +52,7 @@ before_install: | |||
|
|
|||
| script: | |||
| - if [[ "$JOB" == "check_style" ]]; then ./scripts/check_style.sh; fi | |||
| - if [[ "$JOB" == "test" ]]; then ./scripts/tests.sh all; WITH_PYTHON3=ON ./scripts/tests.sh all; fi | |||
There was a problem hiding this comment.
Disable Py3 test for now as Travis CI is having problem installing 'six' package for Py2Py3 compatibility.
jetfuel
approved these changes
Apr 16, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add slider
add restore image
add panning and zooming to graph