Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC- 赛题八:paddleviz能力扩展——Tensor信息展示 #600

Merged
merged 6 commits into from
Sep 20, 2023

Conversation

qiuwenbogdut
Copy link
Contributor

No description provided.

@paddle-bot
Copy link

paddle-bot bot commented Aug 20, 2023

你的PR提交成功,感谢你对开源项目的贡献!
请检查PR提交格式和内容是否完备,具体请参考示例模版
Your PR has been submitted. Thanks for your contribution!
Please check its format and content. For this, you can refer to Template and Demo.

Comment on lines 75 to 77
std::stringstream ss;
ss << this;
std::string this_pointer = ss.str();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这段逻辑应该是不需要

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好的 这边修改下

{}
// Create Grad Node
{}
VLOG(11) << \"Finish AD API GRAD: {}, gradnode_ptr: \"+ this_pointer;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里改成
VLOG(11) << "Finish AD API GRAD: {}, gradnode_ptr: " << this;
就行了

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里原来是不是VLOG(4) << "Finish AD API GRAD: {}"; 啊?原来的代码不要动。
你新加一行:
VLOG(11) << "gradnode_ptr = " << this;

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里原来是不是VLOG(4) << "Finish AD API GRAD: {}"; 啊?原来的代码不要动。 你新加一行: VLOG(11) << "gradnode_ptr = " << this; 吧

确定是修改了原来代码, 那再增加一行,尽量不修改之前代码

Copy link
Contributor

@wanghuancoder wanghuancoder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants