Fix sporadic panic when processing service dependencies #376
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Oops, the error still happens: |
|
With additional traces: |
|
I've added checks to avoid the panic. In real situation, the user will be able to retry in the import. Turns out the When this happens, the acceptance test fails with the following error: |
|
I've added checks to avoid crashing the provider and leave dangling resources when disassociation fails. Tests sometimes still fail, but it feels way less critical like that: |
|
Rebased on master, @stmcallister PTAL. |
…ference` error:
```
make testacc TEST=./pagerduty TESTARGS='-run=TestAccPagerDutyServiceDependency_import -count=1'
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test ./pagerduty -v -run=TestAccPagerDutyServiceDependency_import -count=1 -timeout 120m
=== RUN TestAccPagerDutyServiceDependency_import
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x0 pc=0xf20d08]
goroutine 365 [running]:
github.com/terraform-providers/terraform-provider-pagerduty/pagerduty.resourcePagerDutyServiceDependencyRead(0xc0002de690, {0x11215a0, 0xc000372280})
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/pagerduty/resource_pagerduty_service_dependency.go:195 +0x108
github.com/hashicorp/terraform-plugin-sdk/helper/schema.(*Resource).RefreshWithoutUpgrade(0xc00014df80, 0xc00090b360, {0x11215a0, 0xc000372280})
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/github.com/hashicorp/terraform-plugin-sdk/helper/schema/resource.go:455 +0x1aa
github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin.(*GRPCProviderServer).ReadResource(0xc000010878, {0xc00090b270, 0x503ae6}, 0xc00090b270)
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/github.com/hashicorp/terraform-plugin-sdk/internal/helper/plugin/grpc_provider.go:525 +0x34b
github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5._Provider_ReadResource_Handler({0x1166600, 0xc000010878}, {0x145ad90, 0xc000aaa690}, 0xc00039c9c0, 0x0)
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/github.com/hashicorp/terraform-plugin-sdk/internal/tfplugin5/tfplugin5.pb.go:3153 +0x170
google.golang.org/grpc.(*Server).processUnaryRPC(0xc000b361c0, {0x14701c0, 0xc000298600}, 0xc0007ac300, 0xc0008e8150, 0x1c0d7b0, 0x0)
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/google.golang.org/grpc/server.go:1210 +0xc8f
google.golang.org/grpc.(*Server).handleStream(0xc000b361c0, {0x14701c0, 0xc000298600}, 0xc0007ac300, 0x0)
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/google.golang.org/grpc/server.go:1533 +0xa2a
google.golang.org/grpc.(*Server).serveStreams.func1.2()
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/google.golang.org/grpc/server.go:871 +0x98
created by google.golang.org/grpc.(*Server).serveStreams.func1
/home/patrick/go/src/github.com/PagerDuty/terraform-provider-pagerduty/vendor/google.golang.org/grpc/server.go:869 +0x294
FAIL github.com/terraform-providers/terraform-provider-pagerduty/pagerduty 11.996s
FAIL
make: *** [GNUmakefile:17: testacc] Error 1
```
…e_dependencies/* APIs are eventually consistent
… properly set, and address linter warnings
… as everything is already available in /service_dependencies/associate response
stmcallister
approved these changes
Oct 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes
panic: runtime error: invalid memory address or nil pointer dereferenceerrors that happen from time to time when running acceptance tests:It also enforces that one and only one dependency block must be defined for a
pagerduty_service_dependencyresource given the current implementation: