Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add response_play field to service #515

Merged

Conversation

mattjones753
Copy link
Contributor

@mattjones753 mattjones753 commented May 30, 2022

This PR should allow users to attach a response_play to a service, which is now present in the API. should mean #400 can be closed

depends on a merge to the underlying pagerduty client; heimweh/go-pagerduty#90

@mattjones753 mattjones753 force-pushed the add-response-play-to-service branch 4 times, most recently from cd9d60e to 1926738 Compare June 20, 2022 12:38
@mattjones753 mattjones753 marked this pull request as ready for review June 20, 2022 12:38
@imjaroiswebdev imjaroiswebdev self-requested a review August 5, 2022 15:52
Matt Jones and others added 5 commits August 5, 2022 12:29
@imjaroiswebdev imjaroiswebdev force-pushed the add-response-play-to-service branch from 1926738 to ceab48d Compare August 5, 2022 17:03
@imjaroiswebdev
Copy link
Contributor

Hi there @mattjones753 I want to thank you for doing the integration for response_play on pagerduty_service, I have tested and found that when the service was about to be written and the service the first time doesn't have a response_play assigned the provider was crash. Now that is solved, and I took the chance to add the test cases and the necessary documentation.

I also rebased your branch with the current master state to be consistent at the time of merging.

I want to thank you again for this great work @mattjones753 🎉

Tests results...
Screen Shot 2022-08-04 at 20 35 53

@imjaroiswebdev imjaroiswebdev merged commit 34f717d into PagerDuty:master Aug 5, 2022
@mattjones753 mattjones753 deleted the add-response-play-to-service branch August 20, 2022 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants