d/pagerduty_vendor: Match whole string and fallback to partial matching

[heimweh]

Fixes #54

This PR solves an issue where a vendor search for: "Sentry" would return "IPSentry" instead of "Sentry". To fix this we match the whole string instead.

[ghost]

Hello @heimweh! We also experienced issue #54. Our first solution was to do an exact match too. But this might break backwards compatibility with users who expect to be able to provide partial matches. A more compatible approach might be to prefer the exact match but still support the partial match:

...
var found *pagerduty.Vendor = findVendor(resp.Vendors, searchName)
...

func findVendor(vendors []*pagerduty.Vendor, searchName string) (*pagerduty.Vendor) {
	r := regexp.MustCompile("(?i)" + searchName)
	var closeMatch *pagerduty.Vendor
  for _, vendor := range vendors {
		if searchName == vendor.Name {
			return vendor
		}
		if closeMatch == nil && r.MatchString(vendor.Name) {
			closeMatch = vendor
		}
	}

	return closeMatch
}

[heimweh]

Hi @yeungda-rea, thanks for your input.
I was actually about to tag this as a breaking change, but I totally agree with you.
It's better to fallback to partial matching if the exact match fails, to avoid a breaking change.

Updated the tests, so we should now be able to cover exact (default) and partial matching (fallback).

Note: the exact match is not super-exact, it still allows case-insensitive queries, to allow searching for example: "Sentry" or "sentry".

[ghost]

This implementation looks like it would suit our needs. Looking forward to it being merged so we can stop carrying a patch for bug #54.

[tombuildsstuff]

LGTM 👍