Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Automation Actions' Action association to a Team #600

Merged
merged 8 commits into from
Dec 20, 2022
Merged

Add support for Automation Actions' Action association to a Team #600

merged 8 commits into from
Dec 20, 2022

Conversation

imjaroiswebdev
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev commented Dec 14, 2022 •
edited
Loading

Add support for resource pagerduty_automation_actions_action_team_association

New tests cases introduced...

$ make testacc TESTARGS="-run TestAccPagerDutyAutomationActionsActionTeamAssociation"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccPagerDutyAutomationActionsActionTeamAssociation -timeout 120m
?       github.com/terraform-providers/terraform-provider-pagerduty     [no test files]
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_import
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_import (12.30s)
=== RUN   TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic
--- PASS: TestAccPagerDutyAutomationActionsActionTeamAssociation_Basic (8.39s)
PASS
ok      github.com/terraform-providers/terraform-provider-pagerduty/pagerduty   21.395s

Depends on: heimweh/go-pagerduty#107

@imjaroiswebdev imjaroiswebdev force-pushed the a2actionAssociationWithTeam branch from 9cf9ed0 to 95d5aa9 Compare December 16, 2022 17:42
@imjaroiswebdev imjaroiswebdev force-pushed the a2actionAssociationWithTeam branch from 95d5aa9 to ba2185f Compare December 16, 2022 19:02
@imjaroiswebdev imjaroiswebdev marked this pull request as ready for review December 19, 2022 14:48
stmcallister
stmcallister reviewed Dec 20, 2022
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall, looks great! Just a few minor suggestions before merging.

pagerduty/resource_pagerduty_automation_actions_action_team_association.go Outdated Show resolved Hide resolved
website/docs/r/automation_actions_action_team_association.html.markdown Show resolved Hide resolved
website/docs/r/automation_actions_action_team_association.html.markdown Show resolved Hide resolved
stmcallister
stmcallister approved these changes Dec 20, 2022
View reviewed changes
Copy link
Contributor

@stmcallister stmcallister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 🌮 🎉

@imjaroiswebdev imjaroiswebdev merged commit 90bed94 into PagerDuty:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stmcallister stmcallister stmcallister approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@imjaroiswebdev @stmcallister