Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for data.pagerduty_automation_actions_action #601

Merged
merged 2 commits into from
Jan 9, 2023
Merged

Add support for data.pagerduty_automation_actions_action #601

merged 2 commits into from
Jan 9, 2023

Conversation

mrdubr
Copy link
Contributor

@mrdubr mrdubr commented Dec 19, 2022 •
edited
Loading

Add support for data.pagerduty_automation_actions_action

New test cases introduced:

make testacc TESTARGS="-run TestAccDataSourcePagerDutyAutomationActionsAction_Basic"
==> Checking that code complies with gofmt requirements...
TF_ACC=1 go test $(go list ./... |grep -v 'vendor') -v -run TestAccDataSourcePagerDutyAutomationActionsAction_Basic -timeout 120m
?   	github.com/terraform-providers/terraform-provider-pagerduty	[no test files]
=== RUN   TestAccDataSourcePagerDutyAutomationActionsAction_Basic
--- PASS: TestAccDataSourcePagerDutyAutomationActionsAction_Basic (10.13s)
PASS
ok  	github.com/terraform-providers/terraform-provider-pagerduty/pagerduty	10.471s

@mrdubr mrdubr marked this pull request as ready for review December 19, 2022 18:55
juliannagreen1
juliannagreen1 approved these changes Dec 19, 2022
View reviewed changes
Copy link
Contributor

@juliannagreen1 juliannagreen1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! 🥳

@mrdubr
Copy link
Contributor Author

mrdubr commented Jan 4, 2023

@imjaroiswebdev , @stmcallister , can you please take a look at this one? Thanks!

@imjaroiswebdev imjaroiswebdev self-requested a review January 5, 2023 17:28
imjaroiswebdev
imjaroiswebdev approved these changes Jan 5, 2023
View reviewed changes
Copy link
Contributor

@imjaroiswebdev imjaroiswebdev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @mrdubr! Perfectly implemented. 💪🏽 😎

@imjaroiswebdev imjaroiswebdev merged commit be089bf into PagerDuty:master Jan 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliannagreen1 juliannagreen1 juliannagreen1 approved these changes

@imjaroiswebdev imjaroiswebdev imjaroiswebdev approved these changes

@stmcallister stmcallister Awaiting requested review from stmcallister

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mrdubr @imjaroiswebdev @juliannagreen1