[ORCA-5140] Add support for Event Orchestration External Data Cache Variables #984
Conversation
alenapan
changed the title
| @@ -76,3 +76,5 @@ require ( | |||
| google.golang.org/protobuf v1.33.0 // indirect | |||
| gopkg.in/ini.v1 v1.67.0 // indirect | |||
| ) | |||
|
|
|||
| replace github.com/heimweh/go-pagerduty => github.com/alenapan/go-pagerduty v0.0.0-20250214201653-b8d11443fbc3 | |||
There was a problem hiding this comment.
Annotation: As always, we'll repoint to the correct version of go-pagerduty once https://github.com/heimweh/go-pagerduty/pull/159/files is merged before merging this branch into master.
| "ttl_seconds": { | ||
| Type: schema.TypeInt, | ||
| Computed: true, | ||
| }, | ||
| } | ||
|
|
||
| func checkConfiguration(context context.Context, diff *schema.ResourceDiff, i interface{}) error { | ||
| func checkEventOrchestrationCacheVariableConfiguration(context context.Context, diff *schema.ResourceDiff, i interface{}) error { |
There was a problem hiding this comment.
Annotation: With the addition of the third cache var type I decided to rewrite the validation logic a bit to display a list of required and unsupported attributes for each type. If at least one required attribute is missing, the user will see an error message listing all required attributes for the given type. Same goes for unsupported attributes - the user will se the whole list of unsupported attributes in the error message if at least one such attribute is given.
Error messages are tested in the acceptance tests below.
| @@ -16,7 +16,7 @@ func resourcePagerDutyEventOrchestrationGlobalCacheVariable() *schema.Resource { | |||
| Importer: &schema.ResourceImporter{ | |||
| StateContext: resourcePagerDutyEventOrchestrationGlobalCacheVariableImport, | |||
| }, | |||
| CustomizeDiff: checkConfiguration, | |||
| CustomizeDiff: checkEventOrchestrationCacheVariableConfiguration, | |||
There was a problem hiding this comment.
Annotation: the checkConfiguration function is available to all modules in the provider so I made the name more specific to avoid confusion.
| } | ||
| return nil | ||
| } | ||
|
|
||
| func formatErrors(errors []string) string { |
Changes
This PR adds support for the
external_datacache variable type to the following resources and data sources:pagerduty/resource_pagerduty_event_orchestration_global_cache_variable.gopagerduty/resource_pagerduty_event_orchestration_service_cache_variable.gopagerduty/data_source_pagerduty_event_orchestration_global_cache_variable.gopagerduty/data_source_pagerduty_event_orchestration_service_cache_variable.goIt also extends the documentation for Cache Variable resources and data sources to reflect the new type.
Testing
Provider Changes
Documentation Updates
Used the Doc Preview Tool to test the documentation updates
website/docs/d/event_orchestration_global_cache_variable.html.markdownwebsite/docs/d/event_orchestration_service_cache_variable.html.markdownwebsite/docs/r/event_orchestration_global_cache_variable.html.markdownwebsite/docs/r/event_orchestration_service_cache_variable.html.markdown