-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address ruby 3.0 support #2
Address ruby 3.0 support #2
Conversation
@armiiller Possible to look at this change? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thanks @kimyu92
The upstream now includes this change on its default branch ( |
@kimyu92 Excellent! Did you try to create PR in the upstream? Happy if you do so 🙏 |
cc @armiiller (the original author of these commits) |
Hi @tnir - Are you asking that I make a PR to attr-encrypted/attr_encrypted ? It's been a while since I touched this repo, it was primarily mean as a blog post / temporary gem while users moved from attr_encrypted to native rails encryption. There were no plans to maintain this gem as a "replacement". Native rails encryption should be the solution |
@tnir I'm happy to port the commits to original repo @armiiller you're right about the native rails encryption should be the way to go, however, in real world scenario, it might not be possible to transition to native solution immediately based on the size of app and priority. |
FYI - I think I didn't try to PR these into the main branch because it would be a major breaking change for the attr_encrypted library. You would need some sort of "opt in" configuration so you don't break everything in existing repos that were already using attr_encrypted. The method prefix broke a lot of items, and thus why it was a fork Something to consider if making a PR. Maybe something for an initializer file or something |
Thanks @armiiller. Yes, I asked you so. I agree with @armiiller. I will recheck how the migration in the real world works in a week. |
Since Rails 7 requires minimum ruby 2.7+
This PR is intended to separation of positional and keyword arguments introduced since ruby 2.7 and it's necessary for ruby 3.0