Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Action Required for Translation Files #1185

Closed
palisadoes opened this issue Dec 12, 2023 · 18 comments
Closed

GitHub Action Required for Translation Files #1185

palisadoes opened this issue Dec 12, 2023 · 18 comments
Labels

Comments

@palisadoes
Copy link
Contributor

We need to create a GitHub action that during the PR process checks all the translation files to make sure that there are translations in all the non-default languages for each English default language entry.

As part of the PR for this issue, all the translations must be correctly present

  • NOTE: Please watch this video on how to proceed.
    Click me to start video
@Gmin2
Copy link
Contributor

Gmin2 commented Dec 12, 2023

@noman2002 can i get assigned?

@hharshas
Copy link

can i work on this ??

@RAGHAV-N5
Copy link

I would love to work on this! can i get assigned?

@1010varun
Copy link
Contributor

@noman2002 I want to work on this issue, please assign this to me.

@noman2002
Copy link
Member

Assigned to @Min2who as he commented first.

@Gmin2
Copy link
Contributor

Gmin2 commented Dec 13, 2023

Hey @palisadoes @noman2002 should i make this github action in the push.yml or should make a new yml file

@noman2002
Copy link
Member

Add it in both push and pull_request workflows.

@Gmin2
Copy link
Contributor

Gmin2 commented Dec 15, 2023

Hey @palisadoes @noman2002 some key are not present in the other language as compared to en.json
this would cause all the new PR to fail .Should i make a PR?

@noman2002
Copy link
Member

Please add those missing keys in all other languages.

@Gmin2 Gmin2 removed their assignment Dec 16, 2023
@Gmin2
Copy link
Contributor

Gmin2 commented Dec 16, 2023

anyone want to take it go ahead

@KRIXUS-alpha
Copy link

Hi @noman2002, requesting you to kindly re-assign this issue to me.

@sarthak17jain
Copy link

Hello @noman2002, I have read the codebase and I think that I can solve the issue. Please give me a chance to make my first contribution to the codebase.

Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 28, 2023
@palisadoes
Copy link
Contributor Author

palisadoes commented Dec 28, 2023

Unassigning due to inactivity. We have implemented a similar solution

  1. Script Update: Detailed Error Output for Translation Mismatches talawa#2284

@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 29, 2023
@palisadoes palisadoes reopened this Dec 29, 2023
@1010varun
Copy link
Contributor

@noman2002 can you assign this issue to me. I had commented previously

@1010varun
Copy link
Contributor

Hey @noman2002,
Kindly review my PR once and suggest any changes that need to be added.

@1010varun 1010varun removed their assignment Jan 5, 2024
@1010varun
Copy link
Contributor

Hey @palisadoes,
You can close this issue now.

@palisadoes
Copy link
Contributor Author

This issue was raised to fix this issue.

@palisadoes palisadoes closed this as not planned Won't fix, can't repro, duplicate, stale Sep 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

8 participants