-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added github-workflow for comparing translation file #1325
Added github-workflow for comparing translation file #1325
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Please fix the new failing translation test |
Hey, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- Please use the same file naming convention as this PR for consistency
- The python file is not python
black
,pycodestyle
,pylint
andpydocstyle
compliant. Please fix this.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1325 +/- ##
========================================
Coverage 96.98% 96.99%
========================================
Files 137 137
Lines 3417 3424 +7
Branches 958 961 +3
========================================
+ Hits 3314 3321 +7
Misses 98 98
Partials 5 5 ☔ View full report in Codecov by Sentry. |
@palisadoes, sir I have updated the naming of the file acc. to this PR, kindly review it once. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
See comment
What kind of change does this PR introduce?
Added GitHub workflow for comparing translation files
Issue Number:
Fixes #1185
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
In this PR, I have introduced a GitHub workflow and a Python script that will check all the translation files and reflect the comparisons between different language files with English one.
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Yes