Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added github-workflow for comparing translation file #1325

Merged
merged 8 commits into from
Jan 2, 2024
Merged

Added github-workflow for comparing translation file #1325

merged 8 commits into from
Jan 2, 2024

Conversation

1010varun
Copy link
Contributor

What kind of change does this PR introduce?

Added GitHub workflow for comparing translation files

Issue Number:

Fixes #1185

Did you add tests for your changes?

Snapshots/Videos:

image

If relevant, did you update the documentation?

Summary

In this PR, I have introduced a GitHub workflow and a Python script that will check all the translation files and reflect the comparisons between different language files with English one.

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

Please fix the new failing translation test

@1010varun
Copy link
Contributor Author

Please fix the new failing translation test

Hey,
@palisadoes, sir I have all the failing translation files.
@noman2002 kindly review it once.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Please use the same file naming convention as this PR for consistency
  1. The python file is not python black, pycodestyle, pylint and pydocstyle compliant. Please fix this.

Copy link

codecov bot commented Dec 31, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (6b5c168) 96.98% compared to head (97fb7ac) 96.99%.
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1325   +/-   ##
========================================
  Coverage    96.98%   96.99%           
========================================
  Files          137      137           
  Lines         3417     3424    +7     
  Branches       958      961    +3     
========================================
+ Hits          3314     3321    +7     
  Misses          98       98           
  Partials         5        5           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@1010varun
Copy link
Contributor Author

@palisadoes, sir I have updated the naming of the file acc. to this PR, kindly review it once.

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comment

.github/workflows/compare_translations.py Show resolved Hide resolved
@palisadoes palisadoes self-requested a review January 2, 2024 00:07
@palisadoes palisadoes merged commit 432f117 into PalisadoesFoundation:develop Jan 2, 2024
8 of 9 checks passed
@1010varun 1010varun deleted the 1010varun-translational-files branch January 5, 2024 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants