Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor CSS files in src/screens/ManageTag #2510

Closed
AVtheking opened this issue Nov 30, 2024 · 7 comments
Closed

Refactor CSS files in src/screens/ManageTag #2510

AVtheking opened this issue Nov 30, 2024 · 7 comments
Assignees
Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved

Comments

@AVtheking
Copy link
Contributor

Refactor CSS files in src/screens/ManageTag

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@MayankJha014
Copy link
Contributor

I am starting work on this

@MayankJha014
Copy link
Contributor

#2704

PR for this file

@MayankJha014
Copy link
Contributor

@AVtheking @palisadoes Guys check my recent PR

@gurramkarthiknetha
Copy link
Contributor

If no one is currently working on this issue, I would like to take it on. Please assign it to me.

@palisadoes
Copy link
Contributor

@MayankJha014 You submitted a PR without the issue being assigned. We merged this by accident. Our policy is to ensure PRs are submitted by people assigned the issue to reduce confusion and allow everyone to get a chance to contribute. This is not in keeping with the spirit of the Palisadoes community

@MayankJha014
Copy link
Contributor

@MayankJha014 You submitted a PR without the issue being assigned. We merged this by accident. Our policy is to ensure PRs are submitted by people assigned the issue to reduce confusion and allow everyone to get a chance to contribute. This is not in keeping with the spirit of the Palisadoes community

@palisadoes Sorry Next time this will not happen i will keep in mind

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request good first issue Good for newcomers no-issue-activity No issue activity refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved
Projects
Status: Done
Development

No branches or pull requests

4 participants