Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor: src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest #2749

Closed
palisadoes opened this issue Dec 24, 2024 · 2 comments
Closed

Refactor: src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest #2749

palisadoes opened this issue Dec 24, 2024 · 2 comments
Assignees
@aryanrule
Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Dec 24, 2024 •
edited
Loading

Is your feature request related to a problem? Please describe.
This file is currently tested using Jest. As part of our migration to Vitest, we need to refactor this file's test cases to align with Vitest's syntax and features.

Acceptance Criteria

  1. Replace Jest-specific functions and mocks with Vitest equivalents
  2. Rename the test file from having a .test.* suffix to a .spec.* suffix
  3. Ensure all tests in the file pass after migration using npm run test:vitest
  4. Maintain the test coverage for the file as 100% after migration
  5. Upload a video or photo for this specific file coverage is 100% in the PR description

Additional context

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship
@github-actions github-actions bot added documentation Improvements or additions to documentation refactor Refactor the code to improve its quality test Testing application unapproved labels Dec 24, 2024
@palisadoes palisadoes changed the title Refactor: /setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest Refactor: src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from Jest to Vitest Dec 24, 2024
@palisadoes palisadoes removed the documentation Improvements or additions to documentation label Dec 24, 2024
@aryanrule
Copy link

hi @palisadoes i have identified the issue can you please assign this issue to me !

aryanrule added a commit to aryanrule/talawa-admin that referenced this issue Dec 28, 2024
@aryanrule
refracted jest/vitest issue -(PalisadoesFoundation#2749)
b240fcb
@aryanrule aryanrule mentioned this issue Dec 28, 2024
Closed
@aryanrule
Copy link

hi @palisadoes Closing this PR as it contains unintended changes. I’ll create a cleaner, focused PR shortly—apologies for the confusion!

aryanrule added a commit to aryanrule/talawa-admin that referenced this issue Dec 29, 2024
@aryanrule
refracting jest-to-vitest issue-(PalisadoesFoundation#2749)
6cd3e4d
@aryanrule aryanrule mentioned this issue Dec 29, 2024
Closed
@palisadoes palisadoes added the good first issue Good for newcomers label Dec 29, 2024
aryanrule added a commit to aryanrule/talawa-admin that referenced this issue Dec 31, 2024
@aryanrule
refracting jest to vitest issue-PalisadoesFoundation#2749
8e71d36
@aryanrule aryanrule mentioned this issue Dec 31, 2024
Merged
palisadoes pushed a commit that referenced this issue Dec 31, 2024
@aryanrule
refacted:src/setup/askForTalawaApiUrl/askForTalawaApiUrl.test.ts from…
56c1fbe 
… Jest to Vitest (#3095)

* refracting jest to vitest issue-#2749

* Fix formatting using Prettier

* fix

* fix

* fixed
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Dec 31, 2024
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa-Admin (Tests) Dec 31, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryanrule aryanrule

Labels
good first issue Good for newcomers refactor Refactor the code to improve its quality test Testing application
Projects
Talawa Admin - Refactoring
Status: Done
Talawa-Admin (Tests)
Archived in project
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palisadoes @aryanrule