Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor CSS files in miscellaneous components #2883

Closed
palisadoes opened this issue Dec 26, 2024 · 1 comment
Closed

Refactor CSS files in miscellaneous components #2883

palisadoes opened this issue Dec 26, 2024 · 1 comment
Assignees
@pranavnathe
Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI

Comments

@palisadoes
Copy link
Contributor

Refactor CSS files

To improve the UI/UX of Talawa-Admin we have been working on:

  1. making the application more suitable to color blind users
  2. streamlining all CSS into a single global file

Files

Refactor the typescript files that use these CSS files. In all cases the typescript files reside in the same directory as the corresponding CSS file

  1. src/components/AddOn/core/AddOnEntry/AddOnEntry.module.css
  2. src/components/AddOn/core/AddOnStore/AddOnStore.module.css
  3. src/components/Advertisements/Advertisements.module.css
  4. src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.module.css
  5. src/components/AgendaItems/AgendaItemsContainer.module.css
  6. src/components/EventCalendar/EventCalendar.module.css
  7. src/components/EventCalendar/YearlyEventCalender.module.css
  8. src/components/EventListCard/EventListCard.module.css
  9. src/components/OrgPostCard/OrgPostCard.module.css
  10. src/components/OrgSettings/ActionItemCategories/OrgActionItemCategories.module.css
  11. src/components/RecurrenceOptions/CustomRecurrenceModal.module.css
  12. src/components/UpdateSession/UpdateSession.css
  13. src/components/UserListCard/UserListCard.module.css
  14. src/components/UserPasswordUpdate/UserPasswordUpdate.module.css
  15. src/components/Venues/VenueModal.module.css

Additional information:

  1. The foundational work for this was completed in this PR:
  2. The desired single CSS file is:
    • src/style/app.module.css

The challenge:

The goal is to convert the CSS file in this subdirectory and all the components related to this screen to use this new design pattern. This means that:

  1. All CSS files in this subdirectory and all the CSS files in related components must be merged into the global CSS file using pre-existing CSS.
  2. All CSS files in this subdirectory and all the CSS files in related components must be deleted after the merge.
  3. The remaining relevant files in this subdirectory must only reference the global CSS file.
  4. All the CSS files in the related components of this subdirectory must adhere to the same guidelines.
@github-actions github-actions bot added refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI unapproved good first issue Good for newcomers labels Dec 26, 2024
@pranavnathe
Copy link
Contributor

I’d like to work on this issue. Could you please assign it to me?

This was referenced Dec 26, 2024
Merged
Merged
@pranavnathe pranavnathe mentioned this issue Jan 1, 2025
Merged
palisadoes pushed a commit that referenced this issue Jan 5, 2025
@pranavnathe
#2883 Refactor CSS files in miscellaneous components (#3116)
4548d9d 
* src/components/UpdateSession/UpdateSession.css

* src/components/UserListCard/UserListCard.module.css

* Refactor src/components/UserPasswordUpdate/UserPasswordUpdate.module.css

* src/components/Venues/VenueModal.module.css

* src/components/EventCalendar/YearlyEventCalender.module.css

* Refactor src/components/AgendaItems/AgendaItemsContainer.module.css

* Refactor src/components/AddOn/core/AddOnStore/AddOnStore.module.css

* Refactor src/components/Advertisements/Advertisements.module.css

* Refactor src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.module.css

* Refactor src/components/EventCalendar/EventCalendar.module.css

* Refactor src/components/EventListCard/EventListCard.module.css

* Refactor CSS OrgPostCard.module.css && fixed eslint destructuring props error

* Refactor src/components/OrgSettings/ActionItemCategories/OrgActionItemCategories.module.css

* CSS fix

* consolidating button styles in greenregbtnUserPasswordUpdate

* CSS bugfixes

* Replaced hardcoded color values to CSS variables

* removed role from .calendar__weekdays and .calendar__days

* refactor: extract DeletePostModal from OrgPostCard to fix file-length test

* TSDoc added for src/components/OrgPostCard/DeletePostModal.tsx

* removed duplicate cursor property
@github-project-automation github-project-automation bot moved this from Backlog to Done in Talawa Admin - Refactoring Jan 5, 2025
@palisadoes palisadoes mentioned this issue Jan 20, 2025
Open
This was referenced Jan 22, 2025
Closed
Closed
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pranavnathe pranavnathe

Labels
feature request good first issue Good for newcomers refactor Refactor the code to improve its quality ui/ux issue related and being worked with the figma file of the Admin UI
Projects
2024 New Talawa Admin Screens
Archived in project
Talawa Admin - Refactoring
Status: Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@palisadoes @pranavnathe