-
-
Notifications
You must be signed in to change notification settings - Fork 845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
GitHub Action: Check for embedded CSS and the correct stylesheet in Typescript files #2907
Comments
@palisadoes, please assign me this. |
@IITI-tushar You must add the ability to exclude one or more files from analysis using
|
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
i am working on it. currently trying to fix the conflicting files |
I'm going to close this. It's not appropriate at this time |
i guess once we convert all the CSS to app.module.css then it we should work on this. As since my PR got merged then other PR's are started to fail... since we still are not using app.module.css in all files. |
Can you run your test on only those files submitted in a PR instead, versus the entire code base? |
@palisadoes good idea sir... I will give it a try. |
This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue. |
I am working on it... |
Is your feature request related to a problem? Please describe.
#([0-9a-fA-F]{3}){1,2}
src/style/app.module.css
stylesheet file.github/workflows/eslint_disable_check.py
file that is run as part of our GitHub actions that checks submitted files for statements in the code base that bypass our linting verification.Describe the solution you'd like
.github/workflows/eslint_disable_check.py
file that is run as part of our GitHub actions.src/style/app.module.css
file and no other if a CSS file is used..github/workflows/css_check.py
and must have the CLI option to be run against one or more directories using the--directory
flag like the existing lint check script..github/workflows/eslint_disable_check.py
uses a--directory
flag to define the directory to check. When run as a GitHub action, the script will only see the PR's changed files. Therefore in your testing on your local machine it will find all files on your local machine, but in the PR testing you'll have to edit target files with minor commits to see whether it works for each committed file.develop
anddevelop-postgres
branch workflows in the.github/workflows/pull-request.yml
filepython
black
,pydocstyle
,pylint
,pycodestyle
andflake8
linting and formatting rules applied.It must follow the Google Python Code Style guide, especially the doc string formatting
Describe alternatives you've considered
Approach to be followed (optional)
Additional context
Potential internship candidates
Please read this if you are planning to apply for a Palisadoes Foundation internship
The text was updated successfully, but these errors were encountered: