Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NoMongo: Validate and Fix Login against the postgres-develop branch #3236

Closed
palisadoes opened this issue Jan 10, 2025 · 30 comments
Closed

NoMongo: Validate and Fix Login against the postgres-develop branch #3236

palisadoes opened this issue Jan 10, 2025 · 30 comments

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

  1. We have migrated to the postgres-develop branch of the API
  2. We need to validate and fix the initial login process for the app

Describe the solution you'd like

  • This is up to the person assigned

Describe alternatives you've considered

  • N/A

Approach to be followed (optional)

See above

Additional context

  • N/A

Potential internship candidates

Please read this if you are planning to apply for a Palisadoes Foundation internship

@Prasanth-S7
Copy link

Can I work on this issue?

@IITI-tushar
Copy link
Contributor

@palisadoes I want to work on this. Please assign...

@Prasanth-S7 Prasanth-S7 removed their assignment Jan 10, 2025
@im-vedant
Copy link
Contributor

@palisadoes I would like to work on this issue. Please approve this PR PalisadoesFoundation/switchmap-ng#249, so that I can work on this one.

@Aryan4884
Copy link
Contributor

@palisadoes @dhanagopu I would like to work on this issue if no one working

@Cioppolo14
Copy link
Contributor

@Aryan4884 If the issue has already been assigned, please don't ask to be assigned. We want everyone to get a chance.

@Nikhilh26
Copy link

Nikhilh26 commented Jan 13, 2025

This will not entirely resolve the . For more info see the following Issue

@palisadoes
Copy link
Contributor Author

@im-vedant Were you able to login using the new API?

@palisadoes
Copy link
Contributor Author

@palisadoes I would like to work on this issue. Please approve this PR PalisadoesFoundation/switchmap-ng#249, so that I can work on this one.

This was merged. Are you still working on this?

@im-vedant
Copy link
Contributor

That issue got completed, it was a very old message.

@palisadoes
Copy link
Contributor Author

palisadoes commented Jan 18, 2025

@im-vedant

  1. Are you still working on this?
  2. Did you validate against the postgres-develop branch of the API as stated in the issue?

@im-vedant
Copy link
Contributor

im-vedant commented Jan 18, 2025

  1. Yes, I am working on it.
  2. I am trying to register user, so that I can work on login workflow. There are some errors while registering. I am fixing those errors.

@palisadoes
Copy link
Contributor Author

Thanks. This is holding up others in refactoring the code to handle the new API backend. It's a real priority.

@hustlernik
Copy link
Contributor

@palisadoes I would love to solve some issue related to backend if there is something.

@varshith257
Copy link
Member

varshith257 commented Jan 21, 2025

Note: As priotised issue, we will reassign issue to others if we don't get response in 24 hours

@IITI-tushar
Copy link
Contributor

@varshith257 I am willing to work on it... Please consider me...

@palisadoes
Copy link
Contributor Author

@varshith257 I've been working with @im-vedant on this on slack. There should be some progress in a few days

@NishantSinghhhhh
Copy link
Contributor

If any help is required I am more than happy to contribute to this issue and provide any assistance required to ensure its successful resolution.

@im-vedant im-vedant mentioned this issue Jan 22, 2025
6 tasks
@palisadoes
Copy link
Contributor Author

@palisadoes palisadoes assigned Nikhilh26 and unassigned im-vedant Jan 23, 2025
@palisadoes
Copy link
Contributor Author

Reassigning as explained here:

This is a very rare exception.

@IITI-tushar
Copy link
Contributor

@palisadoes since it is a priority issue. Can I work on this along with @Nikhilh26 ??

@palisadoes
Copy link
Contributor Author

@palisadoes since it is a priority issue. Can I work on this along with @Nikhilh26 ??

Collaborative work has started in the #talawa-projects slack channel

@im-vedant
Copy link
Contributor

@palisadoes you can close this issue.

@github-project-automation github-project-automation bot moved this from Backlog to Done in NoMongo: Talawa-Admin Jan 27, 2025
@rahulch07
Copy link
Contributor

rahulch07 commented Jan 27, 2025

@palisadoes @varshith257

Image

I think this issue is still not completed as only users with regular roles are able to signIn but administrators are not able to signIn

@Nikhilh26 would you please confirm?

@Nikhilh26
Copy link

We have only fixed the login Issue , i.e a user can login but we still have to work alot on other API's as well (and this one also is to be fixed)

@palisadoes
Copy link
Contributor Author

Registration also needs verification

@rahulch07
Copy link
Contributor

@palisadoes @varshith257

would be happy to contribute to this priority issue...made some progress in admin signIn
should I open PR against this issue?

Screencast.from.2025-01-27.18-30-17.webm

@palisadoes
Copy link
Contributor Author

Yes, but create an issue first

@rahulch07
Copy link
Contributor

Yes, but create an issue first

Yes working on test cases. Will make PR after resolving testcases.

@palisadoes
Copy link
Contributor Author

Yes, but create an issue first

Yes working on test cases. Will make PR after resolving testcases.

@rahulch07

  1. We need updated documentation on how to login as part of your PR.
  2. The new INSTALLATION.md should be used

@rahulch07
Copy link
Contributor

Got it! I will update the documentation as part of my PR using the new INSTALLATION.md. I’ll reach out if I have any doubts. Thanks!

@rahulch07 rahulch07 mentioned this issue Jan 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

No branches or pull requests