Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgraded prettier from 2.3.2 to 3.2.5 #1599

Conversation

akhilender-bongirwar
Copy link
Contributor

What kind of change does this PR introduce?
Upgraded prettier to 3.2.5

Issue Number:

Fixes #1591

Did you add tests for your changes?
No

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

  • Upgraded prettier to latest version and matched the version to that of talawa-api
  • Ensured all the tests are passing
  • Ensured no other functionality got affected

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

- Upgraded prettier to latest version and matched the version to that of talawa-api
- Ensured all the tests are passing
- Ensured no other functionality got affected

Signed-off-by: Akhilender <[email protected]>
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@akhilender-bongirwar
Copy link
Contributor Author

2024-02-18.00-14-54.mp4

@palisadoes, I apologize for raising the PR prematurely. As you can see in the above video, the changes were working just fine. I simply wanted to check whether the PR workflow (performing linting) was passing, so I had submitted the pull request.

- Upgraded eslint-plugin-prettier to latest version as it was depended on the prettier version
- Made sure no other functionality got affected and all the tests are passing

Signed-off-by: Akhilender <[email protected]>
Copy link

codecov bot commented Feb 17, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (60fc47c) 96.74% compared to head (6e74715) 96.74%.

Files Patch % Lines
src/utils/StaticMockLink.ts 77.77% 3 Missing and 1 partial ⚠️
...rc/components/AddOn/core/AddOnStore/AddOnStore.tsx 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1599   +/-   ##
========================================
  Coverage    96.74%   96.74%           
========================================
  Files          138      138           
  Lines         3687     3688    +1     
  Branches      1125     1125           
========================================
+ Hits          3567     3568    +1     
  Misses         114      114           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@akhilender-bongirwar
Copy link
Contributor Author

@palisadoes, the PR Workflow, which performs linting, formatting, and type-checking checks, is successful.

@akhilender-bongirwar
Copy link
Contributor Author

akhilender-bongirwar commented Feb 17, 2024

prettier-eslint-issue

  • I have faced the above error when I ran npm run serve

eslint-prettier

  • Even the lint:check didn't work as you can see in the above screen shot.

Hence to resolve this issue and make sure the linting worked properly I have upgraded eslint-plugin-prettier to 5.1.3. (latest version)

@palisadoes
Copy link
Contributor

Is this ready for review now?

@akhilender-bongirwar
Copy link
Contributor Author

Is this ready for review now?

yes sir : )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants