-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgraded prettier from 2.3.2 to 3.2.5 #1599
Upgraded prettier from 2.3.2 to 3.2.5 #1599
Conversation
- Upgraded prettier to latest version and matched the version to that of talawa-api - Ensured all the tests are passing - Ensured no other functionality got affected Signed-off-by: Akhilender <[email protected]>
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
2024-02-18.00-14-54.mp4@palisadoes, I apologize for raising the PR prematurely. As you can see in the above video, the changes were working just fine. I simply wanted to check whether the PR workflow (performing linting) was passing, so I had submitted the pull request. |
- Upgraded eslint-plugin-prettier to latest version as it was depended on the prettier version - Made sure no other functionality got affected and all the tests are passing Signed-off-by: Akhilender <[email protected]>
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## develop #1599 +/- ##
========================================
Coverage 96.74% 96.74%
========================================
Files 138 138
Lines 3687 3688 +1
Branches 1125 1125
========================================
+ Hits 3567 3568 +1
Misses 114 114
Partials 6 6 ☔ View full report in Codecov by Sentry. |
@palisadoes, the PR Workflow, which performs linting, formatting, and type-checking checks, is successful. |
Is this ready for review now? |
yes sir : ) |
440387b
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Upgraded prettier to 3.2.5
Issue Number:
Fixes #1591
Did you add tests for your changes?
No
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes