Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Redesign User sidebar #1933

Merged
merged 10 commits into from
Apr 27, 2024
Merged

Conversation

disha1202
Copy link
Contributor

What kind of change does this PR introduce?
Refactor

Issue Number:

Fixes #1510

Did you add tests for your changes?
Yes

Snapshots/Videos:
Screenshot 2024-04-27 at 3 33 49 PM

Screenshot 2024-04-27 at 3 33 24 PM
test.mov

If relevant, did you update the documentation?

Summary
Redesign user sidebar and also updated the layout

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?
Yes

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.

Unverified

No user is associated with the committer email.
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

 into user-sidebar
Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. From this screen:

    Screenshot 2024-04-27 at 3 33 24 PM
  2. There is no way to get to this screen:

    Screenshot 2024-04-27 at 3 33 49 PM

@palisadoes
Copy link
Contributor

  1. Please find a way to allow the user to access the features of their selected organization.
  2. I tried clicking all over the the Unity Foundation, Queens organization tile without success.
  3. It would be more intuitive to have the "Joined" button say "Visit" with an active link to make the experience more intuitive.

@palisadoes palisadoes linked an issue Apr 27, 2024 that may be closed by this pull request
@disha1202
Copy link
Contributor Author

  1. Please find a way to allow the user to access the features of their selected organization.
  2. I tried clicking all over the the Unity Foundation, Queens organization tile without success.
  3. It would be more intuitive to have the "Joined" button say "Visit" with an active link to make the experience more intuitive.

Sure, I'll update it right away.
Thanks

@disha1202
Copy link
Contributor Author

disha1202 commented Apr 27, 2024

test1-2.mov

Copy link

codecov bot commented Apr 27, 2024

Codecov Report

Attention: Patch coverage is 96.44970% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 98.25%. Comparing base (edd5e73) to head (6cddbcf).

Files Patch % Lines
src/components/IconComponent/IconComponent.tsx 50.00% 2 Missing ⚠️
...s/UserPortal/OrganizationCard/OrganizationCard.tsx 33.33% 2 Missing ⚠️
src/components/ProfileDropdown/ProfileDropdown.tsx 66.66% 1 Missing ⚠️
...nents/UserPortal/UserSidebarOrg/UserSidebarOrg.tsx 97.50% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1933      +/-   ##
===========================================
- Coverage    98.32%   98.25%   -0.07%     
===========================================
  Files          207      210       +3     
  Lines         5536     5675     +139     
  Branches      1633     1699      +66     
===========================================
+ Hits          5443     5576     +133     
- Misses          87       93       +6     
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@palisadoes palisadoes merged commit 4b70197 into PalisadoesFoundation:develop Apr 27, 2024
9 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

USER REDESIGN: redesign the sidenav for the talawa user portal
2 participants