Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix Requests to Membership Requests #1973

Merged
merged 3 commits into from
May 8, 2024
Merged

fix Requests to Membership Requests #1973

merged 3 commits into from
May 8, 2024

Conversation

Ratul-Saha-003
Copy link
Contributor

What kind of change does this PR introduce?
Refactoring

Issue Number:

Fixes #1926

Did you add tests for your changes?
Already present(Updated)

Snapshots/Videos:
Screenshot from 2024-05-07 23-01-14

If relevant, did you update the documentation?
Not Required

Summary
Replace the Requests option with Membership Requests.

Does this PR introduce a breaking change?
No

Other information
None

Have you read the contributing guide?
Yes

Copy link

github-actions bot commented May 8, 2024

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

@Cioppolo14
Copy link
Contributor

@Ratul-Saha-003 Please fix the failing tests.

@Ratul-Saha-003
Copy link
Contributor Author

@Ratul-Saha-003 Please fix the failing tests.

I have updated all the tests concerning this PR.

@varshith257 varshith257 linked an issue May 8, 2024 that may be closed by this pull request
Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.26%. Comparing base (ba5255a) to head (fd65111).

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #1973   +/-   ##
========================================
  Coverage    98.26%   98.26%           
========================================
  Files          210      210           
  Lines         5692     5693    +1     
  Branches      1702     1705    +3     
========================================
+ Hits          5593     5594    +1     
  Misses          93       93           
  Partials         6        6           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

@Atharva-Kanherkar Atharva-Kanherkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@palisadoes palisadoes merged commit e301f94 into PalisadoesFoundation:develop May 8, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update the Requests option wording in the left drawer
5 participants