-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix Requests to Membership Requests #1973
fix Requests to Membership Requests #1973
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
@Ratul-Saha-003 Please fix the failing tests. |
I have updated all the tests concerning this PR. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #1973 +/- ##
========================================
Coverage 98.26% 98.26%
========================================
Files 210 210
Lines 5692 5693 +1
Branches 1702 1705 +3
========================================
+ Hits 5593 5594 +1
Misses 93 93
Partials 6 6 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
e301f94
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Refactoring
Issue Number:
Fixes #1926
Did you add tests for your changes?
Already present(Updated)
Snapshots/Videos:
If relevant, did you update the documentation?
Not Required
Summary
Replace the Requests option with Membership Requests.
Does this PR introduce a breaking change?
No
Other information
None
Have you read the contributing guide?
Yes