Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed error in pledge creation #1978

Merged
merged 1 commit into from
May 11, 2024

Conversation

GlenDsza
Copy link
Contributor

What kind of change does this PR introduce?

bugfix

Issue Number:

Fixes #1977

Did you add tests for your changes?

Yes

Snapshots/Videos:

create_fix.mp4

Summary

  • Error was due to using userId (not present) in admin portal, fixed by using id (present)
  • Refactored few lines of code

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold
  3. Merge conflicts

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

CONTRIBUTING.md

Read our CONTRIBUTING.md file. Most importantly:

  1. PRs with issues not assigned to you will be closed by the reviewer
  2. Fix the first comment in the PR so that each issue listed automatically closes

Other

  1. 🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.
  2. Read the CONTRIBUTING.md file make

Copy link

codecov bot commented May 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.25%. Comparing base (872414a) to head (3d8c369).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1978      +/-   ##
===========================================
- Coverage    98.26%   98.25%   -0.01%     
===========================================
  Files          210      210              
  Lines         5693     5682      -11     
  Branches      1703     1699       -4     
===========================================
- Hits          5594     5583      -11     
  Misses          93       93              
  Partials         6        6              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GlenDsza
Copy link
Contributor Author

There are few design issues in this screen which would be separately handled in #1979

@Cioppolo14 Cioppolo14 requested review from noman2002 and beingnoble03 and removed request for palisadoes and dhanagopu May 11, 2024 16:42
@Cioppolo14
Copy link
Contributor

@noman2002 @beingnoble03 Can you review this PR?

@palisadoes palisadoes merged commit e4b44e9 into PalisadoesFoundation:develop May 11, 2024
12 checks passed
@GlenDsza GlenDsza deleted the dev_pledge branch May 11, 2024 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants