Centralize Translation Functions for Common Keys - Part 1

.github/workflows/compare_translations.py

@@ -98,9 +98,15 @@ def load_translation(filepath):
     Returns:
         translation: Loaded translation
     """
-    with open(filepath, "r", encoding="utf-8") as file:
-        translation = json.load(file)
-    return translation
+    try:
+        with open(filepath, "r", encoding="utf-8") as file:
+            content = file.read()
+            if not content.strip():
+                raise ValueError(f"File {filepath} is empty.")
+            translation = json.loads(content)
+        return translation
+    except json.JSONDecodeError as e:
+        raise ValueError(f"Error decoding JSON from file {filepath}: {e}")
 
 
 def check_translations(directory):
@@ -112,26 +118,36 @@ def check_translations(directory):
     Returns:
         None
     """
-    default_file = "en.json"
-    default_translation = load_translation(os.path.join(directory, default_file))
-    translations = os.listdir(directory)
-    translations.remove(default_file)  # Exclude default translation
+    default_language_dir = os.path.join(directory, "en")
+    default_files = ["common.json", "errors.json", "translation.json"]
+    default_translations = {}
+    for file in default_files:
+        file_path = os.path.join(default_language_dir, file)
+        default_translations[file] = load_translation(file_path)
+
+    languages = os.listdir(directory)
+    languages.remove("en")  # Exclude default language directory
+
 
     error_found = False
 
-    for translation_file in translations:
-        other_file = os.path.join(directory, translation_file)
-        other_translation = load_translation(other_file)
+    for language in languages:
+        language_dir = os.path.join(directory, language)
+        for file in default_files:
+            default_translation = default_translations[file]
+            other_file_path = os.path.join(language_dir, file)
+            other_translation = load_translation(other_file_path)
+
+            # Compare translations and get detailed error messages
+            errors = compare_translations(
+                default_translation, other_translation, f"en/{file}", f"{language}/{file}"
+            )
+            if errors:
+                error_found = True
+                print(f"File {language}/{file} has missing translations for:")
+                for error in errors:
+                    print(f"  - {error}")
 
-        # Compare translations and get detailed error messages
-        errors = compare_translations(
-            default_translation, other_translation, default_file, translation_file
-        )
-        if errors:
-            error_found = True
-            print(f"File {translation_file} has missing translations for:")
-            for error in errors:
-                print(f"  - {error}")
 
     if error_found:
         sys.exit(1)  # Exit with an error status code
@@ -154,7 +170,7 @@ def main():
         "--directory",
         type=str,
         nargs="?",
-        default=os.path.join(os.getcwd(), "public/locales"),
+        default=os.path.join(os.getcwd(), "locales"),
         help="Directory containing translation files(relative to the root directory).",
     )
     args = parser.parse_args()

public/locales/en/common.json

@@ -0,0 +1,51 @@
+{
+  "firstName": "First Name",
+  "lastName": "Last Name",
+  "searchByName": "Search By Name",
+  "loading": "Loading...",
+  "endOfResults": "End of results",
+  "noResultsFoundFor": "No results found for ",
+  "edit": "Edit",
+  "admins": "Admins",
+  "admin": "ADMIN",
+  "user": "USER",
+  "superAdmin": "SUPERADMIN",
+  "members": "Members",
+  "logout": "Logout",
+  "login": "Login",
+  "register": "Register",
+  "menu": "Menu",
+  "settings": "Settings",
+  "users": "Users",
+  "requests": "Requests",
+  "OR": "OR",
+  "cancel": "Cancel",
+  "close": "Close",
+  "create": "Create",
+  "delete": "Delete",
+  "done": "Done",
+  "yes": "Yes",
+  "no": "No",
+  "filter": "Filter",
+  "search": "Search",
+  "description": "Description",
+  "saveChanges": "Save Changes",
+  "displayImage": "Display Image",
+  "enterEmail": "Enter Email",
+  "emailAddress": "Email Address",
+  "email": "Email",
+  "name": "Name",
+  "enterPassword": "Enter Password",
+  "password": "Password",
+  "confirmPassword": "Confirm Password",
+  "forgotPassword": "Forgot Password ?",
+  "talawaAdminPortal": "Talawa Admin Portal",
+  "address": "Address",
+  "location": "Location",
+  "enterLocation": "Enter Location",
+  "joined": "Joined",
+  "startDate": "Start Date",
+  "endDate": "End Date",
+  "startTime": "Start Time",
+  "endTime": "End Time"
+}

public/locales/en/errors.json

@@ -0,0 +1,9 @@
+{
+  "talawaApiUnavailable": "Talawa-API service is unavailable!. Is it running? Check your network connectivity too.",
+  "notFound": "Not found",
+  "unknownError": "An unknown error occurred. Please try again later. {{msg}}",
+  "notAuthorised": "Sorry! you are not Authorised!",
+  "errorSendingMail": "Error sending mail",
+  "emailNotRegistered": "Email not registered",
+  "notFoundMsg": "Oops! The Page you requested was not found!"
+}