-
-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: clashing of create advertisement button with parent div #2157
fix: clashing of create advertisement button with parent div #2157
Conversation
WalkthroughThe recent update introduces a new CSS rule that adds a Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configuration File (
|
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if these conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Files selected for processing (1)
- src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.module.css (1 hunks)
Files skipped from review due to trivial changes (1)
- src/components/Advertisements/core/AdvertisementRegister/AdvertisementRegister.module.css
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2157 +/- ##
========================================
Coverage 97.45% 97.45%
========================================
Files 233 233
Lines 6559 6559
Branches 1927 1927
========================================
Hits 6392 6392
Misses 152 152
Partials 15 15 ☔ View full report in Codecov by Sentry. |
What kind of change does this PR introduce?
bugfix
Issue Number:
Fixes #
#2119
Did you add tests for your changes?
No, not required
Snapshots/Videos:
If relevant, did you update the documentation?
Before:-
![before](https://private-user-images.githubusercontent.com/115611556/355655271-cb32d28e-5545-4a62-8862-3d1aec39aa28.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODU5MjYsIm5iZiI6MTczOTI4NTYyNiwicGF0aCI6Ii8xMTU2MTE1NTYvMzU1NjU1MjcxLWNiMzJkMjhlLTU1NDUtNGE2Mi04ODYyLTNkMWFlYzM5YWEyOC5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNDUzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04ZDhiY2M5YTFhZjA4NTZlYTc2NGQ2NzMxM2NkYWM2OTZmMTIyZGM4MzA1MjE2OTM5ZTUxZmY0MjI0MzM5NTI1JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.XFUZdHxMSrl4jWo4S7BsDdPgQMqt7sM4c9AZjNk94gM)
After:-
![after](https://private-user-images.githubusercontent.com/115611556/355655287-cfae4cdf-7c81-4cd9-8ed4-ac4663580963.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyODU5MjYsIm5iZiI6MTczOTI4NTYyNiwicGF0aCI6Ii8xMTU2MTE1NTYvMzU1NjU1Mjg3LWNmYWU0Y2RmLTdjODEtNGNkOS04ZWQ0LWFjNDY2MzU4MDk2My5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQxNDUzNDZaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT04YTYyYmNkNDJiZWI1Njk2YmNjMjlhYWYzOTlkYzAxYjBhMGJjZWIzZTlhOWI5MGU2YjQ2ZmJiZDFmMTQ4ZmM4JlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.s61G2hlNaLuQkafudOt_55NkhJ_kFIOLdQhuJULpuxo)
Summary
Parent container and create advertisement button were clashing before this issue, i have just added margin-top property at .modalbtn class in AdvertisementRegister component.
Does this PR introduce a breaking change?
No
Other information
Have you read the contributing guide?
Yes
Summary by CodeRabbit