-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: jest to vitest of itemUpdateStatusModal : fixes #2557 #2714
refactor: jest to vitest of itemUpdateStatusModal : fixes #2557 #2714
Conversation
WalkthroughThis pull request focuses on refactoring the Changes
Assessment against linked issues
Possibly related issues
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (1)
🧰 Additional context used📓 Learnings (2)📓 Common learnings
src/screens/OrganizationActionItems/ItemUpdateStatusModal.spec.tsx (1)
🔇 Additional comments (2)src/screens/OrganizationActionItems/ItemUpdateStatusModal.spec.tsx (2)
The mock setup has been correctly migrated from Jest to Vitest, maintaining the same functionality while using the appropriate Vitest APIs.
All mock functions in itemProps have been correctly and consistently updated from Also applies to: 79-80, 152-153 Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #2714 +/- ##
====================================================
+ Coverage 86.10% 86.29% +0.19%
====================================================
Files 295 312 +17
Lines 7259 8134 +875
Branches 1591 1785 +194
====================================================
+ Hits 6250 7019 +769
- Misses 781 943 +162
+ Partials 228 172 -56 ☔ View full report in Codecov by Sentry. |
13aad7c
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Refactoring
Issue Number:
There are multiple test files in this directory. So it needs multiple PRs to close the issue. This PR fixes one such file inside that directory
ItemUpdateStatusModal.spec.tsx
Fixes #2557
Snapshots/Videos:
Summary
Refactored the
ItemUpdateStatusModal.tsx
tests from jest to vitest inItemUpdateStatusModal.spec.tsx
Have you read the contributing guide?
Yes
Summary by CodeRabbit
ItemUpdateStatusModal
component.