-
-
Notifications
You must be signed in to change notification settings - Fork 813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: update Husky configuration and remove deprecated prepare script #3214
chore: update Husky configuration and remove deprecated prepare script #3214
Conversation
WalkthroughThis pull request modifies the Husky configuration in the project by updating the Changes
Assessment against linked issues
Possibly related PRs
Suggested reviewers
Poem
📜 Recent review detailsConfiguration used: .coderabbit.yaml 📒 Files selected for processing (2)
💤 Files with no reviewable changes (1)
🧰 Additional context used🪛 GitHub Actions: PR Workflowpackage.json[error] Unauthorized modification or deletion of sensitive file. Apply 'ignore-sensitive-files-pr' label to override. 🔇 Additional comments (2)
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
🧹 Nitpick comments (1)
package.json (1)
Line range hint
186-189
: Consider updating the lint-staged file patterns.The current patterns have spaces after commas which might cause issues:
"lint-staged": { "**/*.{ts, tsx, json, scss, css}": [ "prettier --write" ], "**/*.{ts, tsx, json}": "eslint --fix" }Remove spaces after commas in the file patterns:
"lint-staged": { - "**/*.{ts, tsx, json, scss, css}": [ + "**/*.{ts,tsx,json,scss,css}": [ "prettier --write" ], - "**/*.{ts, tsx, json}": "eslint --fix" + "**/*.{ts,tsx,json}": "eslint --fix" }
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
.husky/pre-commit
(0 hunks)package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- .husky/pre-commit
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Test Application
- GitHub Check: Analyse Code With CodeQL (javascript)
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop-postgres #3214 +/- ##
=====================================================
+ Coverage 16.54% 89.85% +73.31%
=====================================================
Files 308 329 +21
Lines 7810 8526 +716
Branches 1701 1913 +212
=====================================================
+ Hits 1292 7661 +6369
+ Misses 6429 633 -5796
- Partials 89 232 +143 ☔ View full report in Codecov by Sentry. |
@coderabbitai full review |
✅ Actions performedFull review triggered. |
@coderabbitai full review |
✅ Actions performedFull review triggered. |
5893198
into
PalisadoesFoundation:develop-postgres
What kind of change does this PR introduce?
Issue Number:
Fixes #3168
Before
After
Explaination:-
refs
Before
After
Explaination:-
refs:-
Summary by CodeRabbit