Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code -QL configuration to run on every pull request on all branches #67

Merged
merged 1 commit into from
Jun 6, 2021
Merged

Conversation

akshatgarg12
Copy link
Contributor

…ll branches in pull request

What kind of change does this PR introduce?

Issue Number:

Fixes #62

Did you add tests for your changes?

  • Tested the syntax of yaml file

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

  1. disabled CodeQL github actions on 'push'
  2. removed cron jobs
  3. configured it to run on pull request on all branches.
  4. related issue CodeQL GitHub Action Needs to Run Only on Pull Requests #62

Does this PR introduce a breaking change?
No

Other information

Have you read the contributing guide?
Yes

Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@akshatgarg12 The GitHub Action for CodeQL did not run.

image

@akshatgarg12
Copy link
Contributor Author

Screenshot 2021-06-06 at 11 04 20 PM
@palisadoes It did run on my forked repo! I can see that Code-QL is disabled in the actions here.

@palisadoes
Copy link
Contributor

@akshatgarg12 It's probably because the file is configured for cron in the alpha and master branches. Open PRs for those branches too. I'll ask others to review and merge

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

CodeQL GitHub Action Needs to Run Only on Pull Requests
2 participants