Added 12 new posts to sample_data/posts.json #2837
Conversation
WalkthroughThe pull request introduces multiple new winter-themed pinned posts to the Changes
Assessment against linked issues
Possibly related PRs
Poem
Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Our Pull Request Approval ProcessThanks for contributing! Testing Your CodeRemember, your PRs won't be reviewed until these criteria are met:
Our policies make our code better. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
CONTRIBUTING.mdRead our CONTRIBUTING.md file. Most importantly:
Other
|
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
sample_data/posts.json(1 hunks)src/resolvers/Mutation/togglePostPin.ts(0 hunks)
💤 Files with no reviewable changes (1)
- src/resolvers/Mutation/togglePostPin.ts
⏰ Context from checks skipped due to timeout of 90000ms (2)
- GitHub Check: Testing Application (22.x)
- GitHub Check: Analyse Code With CodeQL (typescript)
🔇 Additional comments (2)
sample_data/posts.json (2)
290-493: Well-structured winter-themed contentThe new posts demonstrate:
- Consistent structure and formatting
- Well-crafted winter-themed narratives
- Appropriate use of the pinned attribute
- Good distribution across different creators and organizations
321-491: Verify the chronological order of postsThe createdAt dates for the new posts span from April 2-13, 2023, which are in the past. Consider whether these should be updated to more recent dates for consistency with the current timeline.
Run this script to check the date distribution:
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2837 +/- ##
===========================================
- Coverage 97.72% 97.68% -0.05%
===========================================
Files 364 364
Lines 18569 18563 -6
Branches 2682 2677 -5
===========================================
- Hits 18147 18133 -14
- Misses 417 425 +8
Partials 5 5 ☔ View full report in Codecov by Sentry. |
palisadoes
added
the
ignore-sensitive-files-pr
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
tests/utilities/loadSampleData.spec.ts (1)
46-46: LGTM! The updated post count matches the PR changes.The change from 17 to 29 posts correctly reflects the addition of 12 new winter-themed posts to sample_data/posts.json.
Consider adding a comment to document the breakdown of posts for better maintainability:
+ // Expect 29 posts: 17 original + 12 winter-themed posts expect(postCount).toBe(29);
|
@palisadoes If you check the togglePostPin.ts file, the title field is optional for toggling a pinned post. However, when unpinning a post, we are not passing the title in the arguments, which is currently causing an error. Therefore, I have removed the code that requires it. Video showing new pinned post : https://www.loom.com/share/5c1ec14e20514dc0b47c47b65cd8ff40 |
@aashimawadhwa PTAL.
|
Looks like the error is fixed, right ?? |
|
@noman2002 The error is fixed. Toggling is working fine. |
palisadoes
requested review from
noman2002
and removed request for
palisadoes and
aashimawadhwa
noman2002
merged commit d6fa933
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Issue Number:
Fixes #2833
Did you add tests for your changes?
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
Summary by CodeRabbit
New Features
Data
Tests