Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for select_contact.dart #1520

Closed
palisadoes opened this issue Feb 18, 2023 · 15 comments · Fixed by #2301
Closed

Tests for select_contact.dart #1520

palisadoes opened this issue Feb 18, 2023 · 15 comments · Fixed by #2301
Assignees
Labels
good first issue Good for newcomers test Testing application

Comments

@palisadoes
Copy link
Contributor

palisadoes commented Feb 18, 2023

The Talawa code base needs to be 100% reliable. This means we need to have 100% test code coverage.

Tests need to be written for file lib/views/after_auth_screens/chat/select_contact.dart

  • When complete, all methods, classes and/or functions in the file will need to be tested.
  • Our test/ folder has the same structure as the lib folder. Place your test file in the equivalent folder under test/. You may need to create the appropriate directory structure to do this.
  • Current test code coverage for this file can be found here

IMPORTANT:

Please refer to this issue on how to implement these tests correctly:

PR Acceptance Criteria

  • When complete this file must show 100% coverage when merged into the code base. This will be clearly visible when you submit your PR.
  • The PR will show a report for the code coverage for the file you have added. You can use that as a guide.
  • You can verify your own code coverage by creating an account at Codecov.io
  • No functionality must be removed to achieve this goal.
@palisadoes palisadoes added the bug Something isn't working label Feb 18, 2023
@github-actions github-actions bot added test Testing application unapproved Unapproved, needs to be triaged labels Feb 18, 2023
@palisadoes palisadoes added points 01 good first issue Good for newcomers and removed bug Something isn't working labels Feb 18, 2023
@literalEval
Copy link
Member

I would like to work on this issue @palisadoes @noman2002

@palisadoes
Copy link
Contributor Author

Thanks for the wanting to be a part of the community.

@literalEval
Copy link
Member

@noman2002 @CyberWake :)

@xoldd xoldd removed the unapproved Unapproved, needs to be triaged label Feb 19, 2023
@noman2002
Copy link
Member

@literalEval I am unassigning this because you have 4 issues assigned and as per rules it cannot be more than 2.

@noman2002 noman2002 added the unapproved Unapproved, needs to be triaged label Feb 21, 2023
@Kraken005
Copy link

Hey, I want to work on this!

@palisadoes palisadoes removed the unapproved Unapproved, needs to be triaged label Feb 25, 2023
@github-actions
Copy link

github-actions bot commented Mar 8, 2023

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 8, 2023
@palisadoes
Copy link
Contributor Author

@Kraken005 Unassigning due to inactivity others need to get a chance. let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@Kraken005
Copy link

Yes, I want to be reassigned. Working on it.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Mar 20, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@palisadoes
Copy link
Contributor Author

There is a PR related to this. Reassigning.

@github-actions github-actions bot removed the no-issue-activity No issue activity label Mar 21, 2023
@palisadoes
Copy link
Contributor Author

Unassigning due to inactivity and no submitted PR. Others need to get a chance. Please let us know whether you want to be reassigned before someone else requests assignment or select another issue.

@github-actions
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Oct 22, 2023
@github-actions github-actions bot removed the no-issue-activity No issue activity label Dec 20, 2023
Copy link

This issue did not get any activity in the past 10 days and will be closed in 180 days if no update occurs. Please check if the develop branch has fixed it and report again or close the issue.

@github-actions github-actions bot added the no-issue-activity No issue activity label Dec 30, 2023
@imshivam-gupta
Copy link
Contributor

@noman2002 @Cioppolo14 Please let me work on this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers test Testing application
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants