-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improved testing select_contact #1645
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.
Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur:
We do this to ensure the overall reliability of the code base is maintained. |
@Kraken005 Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur: The overall code coverage drops below the target threshold of the repository We do this to ensure the overall reliability of the code base is maintained. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the formatting and why there is change in pubspec.lock ?
Codecov Report
@@ Coverage Diff @@
## develop #1645 +/- ##
===========================================
+ Coverage 78.73% 80.63% +1.90%
===========================================
Files 145 144 -1
Lines 7256 7277 +21
===========================================
+ Hits 5713 5868 +155
+ Misses 1543 1409 -134
... and 144 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Kraken005 Any progress on this one ?? |
The code base testing failed at /home/runner/work/talawa/talawa/test/widget_tests/widgets/task_schedule_test.dart. |
Please add documentation for the changes you have made |
Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur:
We do this to ensure the overall reliability of the code base is maintained. This is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing test.
This pull request did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work. |
closing due to a inactivity |
What kind of change does this PR introduce?
This PR improves the testing of select_contact.dart file.
Issue Number:
#1520
Fixes #1520
Did you add tests for your changes?
Yes. I added test for title display.
Summary
A new widget testing for title display. It would overall increase the testing code coverage.
Does this PR introduce a breaking change?
No
Have you read the contributing guide?
Yes