Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved testing select_contact #1645

Closed
wants to merge 9 commits into from

Conversation

Kraken005
Copy link

What kind of change does this PR introduce?

This PR improves the testing of select_contact.dart file.

Issue Number:
#1520

Fixes #1520
Did you add tests for your changes?

Yes. I added test for title display.

Summary

A new widget testing for title display. It would overall increase the testing code coverage.

Does this PR introduce a breaking change?

No

Have you read the contributing guide?

Yes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

@palisadoes
Copy link
Contributor

Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur:

  • The overall code coverage drops below the target threshold of the repository
  • Any file in the pull request has code coverage levels below the repository threshold

We do this to ensure the overall reliability of the code base is maintained.

@Cioppolo14
Copy link
Contributor

@Kraken005 Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

We do this to ensure the overall reliability of the code base is maintained.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the formatting and why there is change in pubspec.lock ?

@codecov
Copy link

codecov bot commented Mar 20, 2023

Codecov Report

Merging #1645 (42b7793) into develop (510d92d) will increase coverage by 1.90%.
The diff coverage is n/a.

❗ Current head 42b7793 differs from pull request most recent head 331c43d. Consider uploading reports for the commit 331c43d to get more accurate results

@@             Coverage Diff             @@
##           develop    #1645      +/-   ##
===========================================
+ Coverage    78.73%   80.63%   +1.90%     
===========================================
  Files          145      144       -1     
  Lines         7256     7277      +21     
===========================================
+ Hits          5713     5868     +155     
+ Misses        1543     1409     -134     
Impacted Files Coverage Δ
lib/views/base_view.dart 100.00% <ø> (ø)

... and 144 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@noman2002
Copy link
Member

@Kraken005 Any progress on this one ??

@Kraken005 Kraken005 requested review from noman2002 and removed request for palisadoes March 21, 2023 15:01
@Kraken005
Copy link
Author

The code base testing failed at /home/runner/work/talawa/talawa/test/widget_tests/widgets/task_schedule_test.dart.

@noman2002
Copy link
Member

Please add documentation for the changes you have made

@palisadoes
Copy link
Contributor

Please fix the failing tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

We do this to ensure the overall reliability of the code base is maintained. This is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix the failing test.

@github-actions
Copy link

This pull request did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

@github-actions github-actions bot added the no-pr-activity No pull request activity label Apr 13, 2023
@palisadoes
Copy link
Contributor

closing due to a inactivity

@palisadoes palisadoes closed this Apr 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-pr-activity No pull request activity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests for select_contact.dart
4 participants