Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert Dart GitHub "Line Counting" action to Python3 #725

Closed
palisadoes opened this issue Apr 26, 2021 · 5 comments · Fixed by #740
Closed

Convert Dart GitHub "Line Counting" action to Python3 #725

palisadoes opened this issue Apr 26, 2021 · 5 comments · Fixed by #740
Assignees
Labels
good first issue Good for newcomers

Comments

@palisadoes
Copy link
Contributor

Is your feature request related to a problem? Please describe.

Issue #700 was created to help improve Dart file code quality by limiting the size of files submitted in pull requests. This issue was closed with pull request #724

PR #724 created these two files:

  1. countline.sh
  2. countlines.yml

Describe the solution you'd like

  1. We need the countline.sh script converted to python3. It's a more universally taught language and will make future support easier.
  2. We need countlines.yml to reference the new python3 file.
  3. The code must:
    1. comply with the Google Python Style Guide which is heavily based on passing the pylint checks.
    2. Pass the pydocstyle, pycodestyle and pep8 tests that can be installed using pip3. Most commonly used IDEs (atom.io) support including these packages and pylint. The IDE will alert you to non compliance
  4. Delete the countline.sh script
  5. The python3 script must:
    1. exit with a code 0 when successful and code 1 when it fails
    2. have identical text output to the current script.
    3. be proven to work as a GitHub action as part of the PR process

Describe alternatives you've considered

N/A

Approach to be followed (optional)

See section above

Additional context

Kudos to @StrangeNoob for working on the original issue, who may be able to provide some guidance.

@github-actions github-actions bot added the unapproved Unapproved, needs to be triaged label Apr 26, 2021
@sumitra19jha
Copy link
Contributor

@palisadoes I have previously worked in Python 3 but I have never implemented this work in any of the previous flutter projects I have worked on. But still, I would like to take up this issue and resolve it. It will increase my knowledge.

@Sagar2366 Sagar2366 removed the unapproved Unapproved, needs to be triaged label Apr 26, 2021
@palisadoes
Copy link
Contributor Author

palisadoes commented Apr 26, 2021

  1. Use os.walk
  2. Here's an example

Please focus on readability and compliance with the pip3 packages mentioned.

@sumitra19jha
Copy link
Contributor

Sure @palisadoes

@palisadoes
Copy link
Contributor Author

@sumitra19jha Also use Argparse instead of getting the argument using $1

@sumitra19jha
Copy link
Contributor

@sumitra19jha Also use Argparse instead of getting the argument using $1

Ok I will do that

Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
…dation#725)

* check authentication feature added for talawa admin

* tests for check authentication added

* minor fixes

* typo fixes

* minor fixes

* npm err fixes

* google recaptcha configured

* new dependency added

* mailer, forgotPassword endpoint and otp endpoint is configured

* graphql endpoints updated

* constants updated

* Documentation updated

* tests for changes added

* hard coded value error fixes

* lint fixes

* lint fixes

* failed test cases fixes

* Failed tests fixes

* minor fixes

* marked-teminal dependency updated

* Tests fixes

* tests updated

* tests fixes

* tests updated

* new resolvers added and schema updated

* graphql mutations updated

* tests updated for changes

* tests updated

* tests updated

* tests updated

* minor fixes
Ayush0Chaudhary pushed a commit to Ayush0Chaudhary/talawa that referenced this issue Mar 29, 2023
* Removed package easygraphql-tester (PalisadoesFoundation#747)

Removed the package named easygraphql-tester because it was not being used anywhere in the app and had a security vulnerability.

* Revert "Removed package easygraphql-tester (PalisadoesFoundation#747)" (PalisadoesFoundation#753)

This reverts commit 61818a1e6484f39b66bd3105ca2dda8d7396f62f.

* Bump moment-timezone from 0.5.34 to 0.5.37 (PalisadoesFoundation#757)

Bumps [moment-timezone](https://github.com/moment/moment-timezone) from 0.5.34 to 0.5.37.
- [Release notes](https://github.com/moment/moment-timezone/releases)
- [Changelog](https://github.com/moment/moment-timezone/blob/develop/changelog.md)
- [Commits](moment/moment-timezone@0.5.34...0.5.37)

---
updated-dependencies:
- dependency-name: moment-timezone
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Doubled the number of retries

The tests have been failing due to timeouts.

* add mongodb credentials in github actions yml file

* update github actions mongodb parameters

* update variable names in github actions

* update github actions push file

* revert github actions push file

* add start period for health check in github actions

* add extra health check parameters for mongo

* adjust mongo image version

* explicitly add mongo version to image for github actions

* Removed package easygraphql-tester (PalisadoesFoundation#754)

* Code Coverage : Tests for groups.js Fix PalisadoesFoundation#585 (PalisadoesFoundation#769)

* Create groups.spec.js

* Update groups.spec.js

* Update getPlugins.spec.js

* Update CONTRIBUTING.md

* Update CONTRIBUTING.md

* Bump jose from 2.0.5 to 2.0.6 (PalisadoesFoundation#770)

Bumps [jose](https://github.com/panva/jose) from 2.0.5 to 2.0.6.
- [Release notes](https://github.com/panva/jose/releases)
- [Changelog](https://github.com/panva/jose/blob/v2.0.6/CHANGELOG.md)
- [Commits](panva/jose@v2.0.5...v2.0.6)

---
updated-dependencies:
- dependency-name: jose
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump file-type and image-hash (PalisadoesFoundation#752)

Bumps [file-type](https://github.com/sindresorhus/file-type) and [image-hash](https://github.com/danm/image-hash). These dependencies needed to be updated together.

Updates `file-type` from 14.7.1 to 16.5.4
- [Release notes](https://github.com/sindresorhus/file-type/releases)
- [Commits](sindresorhus/file-type@v14.7.1...v16.5.4)

Updates `image-hash` from 4.0.1 to 5.3.1
- [Release notes](https://github.com/danm/image-hash/releases)
- [Commits](https://github.com/danm/image-hash/commits)

---
updated-dependencies:
- dependency-name: file-type
  dependency-type: indirect
- dependency-name: image-hash
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump got and nodemon (PalisadoesFoundation#771)

Bumps [got](https://github.com/sindresorhus/got) and [nodemon](https://github.com/remy/nodemon). These dependencies needed to be updated together.

Removes `got`

Updates `nodemon` from 2.0.15 to 2.0.20
- [Release notes](https://github.com/remy/nodemon/releases)
- [Commits](remy/nodemon@v2.0.15...v2.0.20)

---
updated-dependencies:
- dependency-name: got
  dependency-type: indirect
- dependency-name: nodemon
  dependency-type: direct:development
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Bump vm2 from 3.9.9 to 3.9.11 (PalisadoesFoundation#772)

Bumps [vm2](https://github.com/patriksimek/vm2) from 3.9.9 to 3.9.11.
- [Release notes](https://github.com/patriksimek/vm2/releases)
- [Changelog](https://github.com/patriksimek/vm2/blob/master/CHANGELOG.md)
- [Commits](patriksimek/vm2@3.9.9...3.9.11)

---
updated-dependencies:
- dependency-name: vm2
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <[email protected]>

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Feature Request :  Performing Donations ( Ability to store donation transaction in Talwa-api )  (PalisadoesFoundation#756)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* Create cancel_membership_request.spec.js

* Update cancel_membership_request.js

* Update cancel_membership_request.spec.js

* Update cancel_membership_request.js

* `Typo`

* Add : Donation Model

* Add : getDonations Query

* Add : Schema for Donation

* Add : Schema for getDonations query

* Add : getDonationById Query

* Add : Schema for getDonationById

* Fix : `Donation Model`

* Add : createDonation Mutation

* Add : createDonation Schema

* Updated Donation Model

* Add :  `createDonation` GraphQL Mutation

* Fix : `getDonationById` Query

* Add : `getDonationByOrgId` Query

* Update : Scehma Updated due to change in `Donation` Model

* Update : `Donation` Schema in .graphql

* Add : `getDonationById` and `getDonationByOrgId` in gql schema

* Add : gql Schema for `DeletePayload`

* Add : `deleteDonationById` Mutation

* Chores : Formatting files

* Fix : Lint errors

* Test for send_membership_request.js (PalisadoesFoundation#763)

* test for reject_membership_request.js

* send_membership_request.spec.js initialized

* test for send_membership_request.js

* fixes in test for send membership request

* minor fixes in send_membership_request.spec.js

* 100% test coverage

Co-authored-by: Nishant <[email protected]>

* Talawa api multitenancy (PalisadoesFoundation#776)

* Initial setup (PalisadoesFoundation#726)

* Initial setup

* simplified creation

* added readme.md file

* added connection manager and id helper functions

* Error handling & security updates (PalisadoesFoundation#744)

* [Feature Request] New Features for Talawa-admin added (PalisadoesFoundation#725)

* check authentication feature added for talawa admin

* tests for check authentication added

* minor fixes

* typo fixes

* minor fixes

* npm err fixes

* google recaptcha configured

* new dependency added

* mailer, forgotPassword endpoint and otp endpoint is configured

* graphql endpoints updated

* constants updated

* Documentation updated

* tests for changes added

* hard coded value error fixes

* lint fixes

* lint fixes

* failed test cases fixes

* Failed tests fixes

* minor fixes

* marked-teminal dependency updated

* Tests fixes

* tests updated

* tests fixes

* tests updated

* new resolvers added and schema updated

* graphql mutations updated

* tests updated for changes

* tests updated

* tests updated

* tests updated

* minor fixes

* [Feature Request] : Plugin Architecture for Server (PalisadoesFoundation#730)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* added delimiter to helper functions

* error handling for connection manager

* added readme.md for connection manager

* error handling for Database module

Co-authored-by: Asmit Kumar Sirohi <[email protected]>
Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]>

* Create new tenant on createOrganization

* Custom schema functionality

* Added the context function

* modify createPost resolver

* fix createPost, createOrganization resolvers

* Initial setup (PalisadoesFoundation#726)

* Initial setup

* simplified creation

* added readme.md file

* added connection manager and id helper functions

* Error handling & security updates (PalisadoesFoundation#744)

* [Feature Request] New Features for Talawa-admin added (PalisadoesFoundation#725)

* check authentication feature added for talawa admin

* tests for check authentication added

* minor fixes

* typo fixes

* minor fixes

* npm err fixes

* google recaptcha configured

* new dependency added

* mailer, forgotPassword endpoint and otp endpoint is configured

* graphql endpoints updated

* constants updated

* Documentation updated

* tests for changes added

* hard coded value error fixes

* lint fixes

* lint fixes

* failed test cases fixes

* Failed tests fixes

* minor fixes

* marked-teminal dependency updated

* Tests fixes

* tests updated

* tests fixes

* tests updated

* new resolvers added and schema updated

* graphql mutations updated

* tests updated for changes

* tests updated

* tests updated

* tests updated

* minor fixes

* [Feature Request] : Plugin Architecture for Server (PalisadoesFoundation#730)

* Test : lib/resolvers/group_chat_query/groupChatMessages.js

* Add Test  : Added Valid JSON Check

* Create README.md

* Create README.md

* Update is-auth.js

* AddedDocs

Docs from withfilter pending

* Update index.js

* completed

* sample

* update/index.js

* update/index.js

* update/is-auth.js

* Update/readme.md

* update/image-readme

* Add/query-schema

* Update/Plugin-graphQL-schema

* Add/Plugin-MongoDB-Model

* Add/createPlugin-and-refractoring

* Add/getPlugins

* Add/Mutation/UpdatePluginStatus

* Add/Mutation/updateTempPluginInstalledOrgs

* Add/Mutation/Schema

* Add/import/mutations

* Add/plugins

* Fix/path-err

* Fix/Erros

* update/lockfile

* Add/plugin-model

* Update is-auth.js

* Removed extra queries

* Documentation added for plugin queries and models

* Fix/`delelte cr in prettier/prettier`

* updated : mutation

* Add/test `getPlugins`

* Fix/`lint error`

* test `updatePluginInstalledOrgs`

* Test/ `updateInstallStatus`

* Fix/Erros-1

* Fix/Erros-2

* Fix/Erros-3

* Test/`Queries.js`

* Test/`Mutation.js`

* remove extra `console.log`

* Delete admin-plugin-query.js

* Delete super-admin-plugin-query.js

* Fix/Package-lock

* added delimiter to helper functions

* error handling for connection manager

* added readme.md for connection manager

* error handling for Database module

Co-authored-by: Asmit Kumar Sirohi <[email protected]>
Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]>

* dynamic functionality additions

* update tenant schema folder

* modify all posts-comments resolvers

* resolve failing tests for posts modifications

* modify events-tasks-projects related resolvers

* resolve failing tests

* modified user queries

* modify longin mutation to return events properly

* modify org mutations and resolve failing tests

* diconnect properly from the database

* if not connection for org search in the database for it

* group chats and direct chats mutations

* remove console logs

* remove unnecessary comments

* fix drop database

Co-authored-by: Mickey <[email protected]>
Co-authored-by: Asmit Kumar Sirohi <[email protected]>
Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]>
Co-authored-by: JamaicanFriedChicken <[email protected]>

* interchanged .env and .env.sample from the installation guide (PalisadoesFoundation#774)

* Migrated develop branch to typescript including the changes till october 19, 2022

* Added some comments and reinstalled some packages to match the main repository's package.json

* Github actions update

* getLanguage.spec.ts import fix

* forgotPassword.spec.ts fix

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: Peter Harrison <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: JamaicanFriedChicken <[email protected]>
Co-authored-by: Siddhesh Bhupendra Kuakde <[email protected]>
Co-authored-by: Nishant Singh <[email protected]>
Co-authored-by: Nishant <[email protected]>
Co-authored-by: Ebrahim <[email protected]>
Co-authored-by: Mickey <[email protected]>
Co-authored-by: Asmit Kumar Sirohi <[email protected]>
Co-authored-by: Kanishka Bansode <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants