Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #1250 Improved code coverage of recover.dart #1274

Merged

Conversation

noman2002
Copy link
Member

@noman2002 noman2002 commented Mar 17, 2022

What kind of change does this PR introduce?
Testing

Issue Number:
Fixes #1250

Did you add tests for your changes?
Yes

Snapshots/Videos:
N/A

If relevant, did you update the documentation?
N/A

Summary
Improved test of recover.dart to get 100% codecoverage

Does this PR introduce a breaking change?
No

Have you read the contributing guide?
Yes

@codecov-commenter
Copy link

codecov-commenter commented Mar 18, 2022

Codecov Report

Merging #1274 (7f8a6e0) into develop (615b5b6) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1274      +/-   ##
===========================================
+ Coverage    60.08%   60.11%   +0.03%     
===========================================
  Files          125      125              
  Lines         6363     6363              
===========================================
+ Hits          3823     3825       +2     
+ Misses        2540     2538       -2     
Impacted Files Coverage Δ
lib/main.dart 1.56% <0.00%> (ø)
lib/views/pre_auth_screens/recover.dart 100.00% <0.00%> (+4.16%) ⬆️

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@DeltaHarbinger
Copy link
Contributor

Hello @noman2002 , Thank you for making this PR. Once you remove the "print" statements, I can merge this

TheHazeEffect
TheHazeEffect previously approved these changes Mar 19, 2022
Copy link
Contributor

@palisadoes palisadoes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the print statements.

@noman2002
Copy link
Member Author

Thank you for your feedback. I have made the required changes. Please review it.

@palisadoes palisadoes merged commit 104f2c4 into PalisadoesFoundation:develop Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Views: Create tests for recover.dart
5 participants