Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes#1247 Add the test for SingUpDetail screen #1430

Conversation

Ayush0Chaudhary
Copy link
Contributor

What kind of change does this PR introduce?

Issue Number:

Fixes #1247

Did you add tests for your changes?
Yes, I added the unittest only

Summary
I added the test for sign up detail screen
Does this PR introduce a breaking change?
no

Have you read the contributing guide?
yes

@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/signup_unittest branch from ff8c7e0 to c2681a3 Compare January 26, 2023 18:42
@Ayush0Chaudhary Ayush0Chaudhary marked this pull request as ready for review January 26, 2023 23:58
@Ayush0Chaudhary
Copy link
Contributor Author

Ayush0Chaudhary commented Jan 27, 2023

@noman2002 @palisadoes @SiddheshKukade @TheHazeEffect
I got 100% coverage in Signup page.
Screenshot from 2023-01-27 05-30-15

Please review the PR mentors.

@palisadoes
Copy link
Contributor

@Ayush0Chaudhary Please fix the failing tests. You have probably not updated your local branch with the latest version of the code base.

@Ayush0Chaudhary
Copy link
Contributor Author

I merged the latest commit from develop to my branch @palisadoes @noman2002

@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/signup_unittest branch from fdd35f6 to aa8bdd2 Compare January 27, 2023 10:06
@Ayush0Chaudhary
Copy link
Contributor Author

@palisadoes @noman2002 you can check it now!!
It should pass all the test now.
@SiddheshKukade @TheHazeEffect

@codecov-commenter
Copy link

codecov-commenter commented Jan 27, 2023

Codecov Report

Merging #1430 (aa8bdd2) into develop (b8960ac) will increase coverage by 1.70%.
The diff coverage is n/a.

❗ Current head aa8bdd2 differs from pull request most recent head da41cdd. Consider uploading reports for the commit da41cdd to get more accurate results

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@             Coverage Diff             @@
##           develop    #1430      +/-   ##
===========================================
+ Coverage    68.38%   70.08%   +1.70%     
===========================================
  Files          144      144              
  Lines         7164     7164              
===========================================
+ Hits          4899     5021     +122     
+ Misses        2265     2143     -122     
Impacted Files Coverage Δ
lib/views/pre_auth_screens/signup_details.dart 100.00% <ø> (+100.00%) ⬆️
lib/router.dart 42.20% <0.00%> (+2.75%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@Ayush0Chaudhary
Copy link
Contributor Author

Ayush0Chaudhary commented Jan 27, 2023

@noman2002 I added them back
you were right about it.

@Ayush0Chaudhary
Copy link
Contributor Author

@noman2002 sir, what about this PR??
can we merge it??

@noman2002
Copy link
Member

@noman2002 sir, what about this PR?? can we merge it??

Yes we are good to go.

@palisadoes palisadoes merged commit f381ac8 into PalisadoesFoundation:develop Jan 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Views: Create tests for signup_details.dart
4 participants