Bug Fix: Adding back the plugin architecture logic for talawa app #1778

SiddheshKukade · 2023-04-14T03:24:42Z

What kind of change does this PR introduce?
Refactoring

Issue Number:

Did you add tests for your changes?
Not required.
Snapshots/Videos:

block diagram for overview:

Screenrecorder-2023-05-03-10-23-20-667.mp4

If relevant, did you update the documentation?
To make it work with mongoDB ,talawa-api , talawa-admin we have to firstly store some data in the db and then we can use the store further
The plugins collection should have follwing with proper orgIDs for testing puroposes:

 {
        "_id": "63929c1915ad470d13c3bcb6",
        "pluginInstallStatus": true,
        "pluginName": "Events",
        "pluginCreatedBy": " Mr. Siddhesh Bhupendra  Kukade",
        "pluginDesc":
            "Presenting the Events Plugin by Siddhesh Bhupendra Kuakde that implements the plugin features as a component here members can create and manage events and on top of it everything is controlled by the Organization Admins . Install and use right away.",
        "installedOrgs": [
          "62ccfccd3eb7fd2a30f41601",
          "62ccfccd3eb7fd2a30f41601",
          "<YOUR_ORG_ID_FOR_DEVELOPMENT>"
        ]
      },
      {
        "_id": "63929c1915ad470d13c3bcb6",
        "pluginInstallStatus": true,
        "pluginName": "Posts",
        "pluginCreatedBy": "Mr.Johnathan Doe ",
        "pluginDesc":
            "Presenting the Donation plugin for the talawa app that enables members of the organization to  do One time or Reccurinng donations to an  organization",
        "installedOrgs": [
          "62ccfccd3eb7fd2a30f41601",
          "62ccfccd3eb7fd2a30f41601",
          "<YOUR_ORG_ID_FOR_DEVELOPMENT>"
        ]
      },
      {
        "_id": "62cfcf71824dc26e1fbeed46",
        "pluginInstallStatus": true,
        "pluginName": "Donation",
        "pluginCreatedBy": "Kimia",
        "pluginDesc":
            "See all available organizations in entire world using this plugins",
        "installedOrgs": [
          "62ccfccd3eb7fd2a30f41601",
          "<YOUR_ORG_ID_FOR_DEVELOPMENT>"
        ]
      },
      {
        "_id": "62cfcf71824dc26e1fbeed46",
        "pluginInstallStatus": true,
        "pluginName": "Chats",
        "pluginCreatedBy": "Kimia",
        "pluginDesc":
            "See all available organizations in entire world using this plugins",
        "installedOrgs": [
          "62ccfccd3eb7fd2a30f41601",
          "<YOUR_ORG_ID_FOR_DEVELOPMENT>"
        ]
      }

Summary
Added the 15 sec delay to plugin calls and added back the previous deletions.

Does this PR introduce a breaking change?
No

Have you read the contributing guide?

Yes

github-actions · 2023-04-14T03:25:17Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

literalEval · 2023-04-14T05:13:15Z

@palisadoes @SiddheshKukade please tag me once this is ready for review. Since I worked on refactoring, I can advise a thing or two in this PR. Thanks.

palisadoes · 2023-04-14T16:30:15Z

Thanks for submitting your PR, but we must close it.

We get notified of every event in the queue, and draft PRs like these, and their updates that require no action can be a distraction. We need our reviewers to focus on updates that are ready.
Don't be discouraged, we are just trying to keep our workloads to a manageable level.

Please resubmit when you are ready.

SiddheshKukade · 2023-04-14T17:00:29Z

@palisadoes Sir, sorry I wasn't aware about the notification thing.
I just opened the PR as draft to check for any CI/CD error that might occur.

It's alright, I'll figure out something else to check that 👍

SiddheshKukade · 2023-05-03T14:40:01Z

@palisadoes, Sir the code for this is ready reviewed, please re-open this PR to see the latest commits.

palisadoes · 2023-05-03T14:48:00Z

Please remove the draft status from this PR.

literalEval · 2023-05-03T14:59:30Z

@SiddheshKukade please have a look at the previously refactored code and bug fixes thoroughly, so that we don't reinvent the wheel :)

lib/views/main_screen.dart

lib/main.dart

lib/views/main_screen.dart

SiddheshKukade · 2023-05-03T16:27:48Z

@SiddheshKukade please have a look at the previously refactored code and bug fixes thoroughly, so that we don't reinvent the wheel :)

@literalEval I've already fetched everything latest from all the repos.

literalEval · 2023-05-03T16:46:04Z

@SiddheshKukade don't mark reviews as resolved without the mentors and admins commenting on it.

@palisadoes please have a look at the reviews I have provided. Thanks

SiddheshKukade · 2023-05-03T16:47:15Z

@DMills27 Sir, I would also like to your thoughts on this.

I've also updated the description with more details.

palisadoes · 2023-05-14T03:07:09Z

@SiddheshKukade please get your mentors to review and approve this.

SiddheshKukade · 2023-05-14T06:42:27Z

@SiddheshKukade please get your mentors to review and approve this.

@palisadoes Sure, Actually, some tasks were pending before this merged to avoid inconsistencies. I'll link them here 👍🏻

palisadoes · 2023-05-31T03:00:14Z

Have the dependencies for this PR been resolved?
Should it be closed or should it be reviewed?

literalEval · 2023-05-31T04:53:34Z

@palisadoes Since the plugin system is a GSoC project anyway, and since no project directly depends on this, I think instead of reintroducing the previous work, we can wait till @SiddheshKukade fixes everything this time, and close this PR without a merge.

SiddheshKukade · 2023-05-31T05:08:03Z

@palisadoes sir, I'm having practical exams from the past 2 weeks. Due to that I had to take a break untill 3rd june. I have also discussed that with my mentor tasneem mam.
My other PRs need to be merged before this get merged to avoid inconsistencies.

I'll get started to complete that In a few days and there is no need to close the PR.
Thanks

github-actions · 2023-06-11T00:23:42Z

This pull request did not get any activity in the past 10 days and will be closed in 365 days if no update occurs. Please verify it has no conflicts with the develop branch and rebase if needed. Mention it now if you need help or give permission to other people to finish your work.

palisadoes · 2023-06-11T00:48:35Z

@SiddheshKukade What should we do about this PR?

palisadoes · 2023-06-11T00:49:01Z

@tasneemkoushar @DMills27 Please add your comments

SiddheshKukade · 2023-06-11T11:30:24Z

@SiddheshKukade What should we do about this PR?

@palisadoes Sir, currently this should PR be kept on hold because merging this before resolving PalisadoesFoundation/talawa-api#1337 can create problem for other contributors for developing the app without having the basic plugin data in their database. Please wait until the PR for api#1337 is merged.

SiddheshKukade · 2023-06-16T16:35:41Z

Update: I was thinking about adding the websockets logic (which is next step in my project ) in this PR
This will ensure that other contributors would not face any problems with their work regarding plugins.

So for that reason this pull request has to be kept open for a few more days.

noman2002

Rest everything looks good to me but Why the error is coming in the start of video ?

noman2002 · 2023-07-25T11:59:33Z

lib/plugins/fetch_plugin_list.dart

  FetchPluginList() {
+    print(
+        "Fetching pligins =================================================================");
    fetchList();


Remove print statements

Yes, actually I need to add the socket listeners ( GraphQL Subscriptions) .

feat: add back the navbar plugin logic

06c8468

SiddheshKukade mentioned this pull request Apr 14, 2023

Bug Report: Adding back the plugin architecture logic for talawa-admin PalisadoesFoundation/talawa-admin#859

Closed

palisadoes requested review from Sagar2366, TheHazeEffect, AdityaBirangal, CyberWake and noman2002 April 14, 2023 12:14

palisadoes closed this Apr 14, 2023

SiddheshKukade added 2 commits May 3, 2023 07:31

Merge branch 'PalisadoesFoundation:develop' into fix-1758

0aea700

Added 15 sec delays: while fetching plugins

c79c2b6

palisadoes reopened this May 3, 2023

literalEval requested changes May 3, 2023

View reviewed changes

lib/views/main_screen.dart Show resolved Hide resolved

lib/views/main_screen.dart Show resolved Hide resolved

lib/main.dart Show resolved Hide resolved

lib/views/main_screen.dart Show resolved Hide resolved

SiddheshKukade marked this pull request as ready for review May 3, 2023 16:26

SiddheshKukade changed the title ~~Bug Fix: Adding back the plugin architecture logic for talawa app [Work in progress]~~ Bug Fix: Adding back the plugin architecture logic for talawa app May 3, 2023

SiddheshKukade mentioned this pull request May 6, 2023

Bug Report: Adding back the plugin architecture logic for talawa app #1758

Closed

Refactor: removed extra print statements

9117db1

SiddheshKukade mentioned this pull request May 10, 2023

WEEK 01 REPORT 01 SiddheshKukade/Google-Summer-of-Code-2023-Work-Product#4

Closed

Temp # fix later

5eab95d

github-actions bot added the no-pr-activity No pull request activity label Jun 11, 2023

SiddheshKukade added wip Work in Progress area/performance pr/do-not-merge Can't merge due to merge-conflicts of files or a important review is required. and removed no-pr-activity No pull request activity labels Jun 11, 2023

SiddheshKukade mentioned this pull request Jun 16, 2023

Feature Request: auto populating plugin data during the initial server setup. PalisadoesFoundation/talawa-api#1345

Merged

noman2002 reviewed Jul 25, 2023

View reviewed changes

SiddheshKukade closed this Sep 3, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bug Fix: Adding back the plugin architecture logic for talawa app #1778

Bug Fix: Adding back the plugin architecture logic for talawa app #1778

SiddheshKukade commented Apr 14, 2023 •

edited

Loading

github-actions bot commented Apr 14, 2023

literalEval commented Apr 14, 2023

palisadoes commented Apr 14, 2023

SiddheshKukade commented Apr 14, 2023

SiddheshKukade commented May 3, 2023

palisadoes commented May 3, 2023

literalEval commented May 3, 2023

SiddheshKukade commented May 3, 2023

literalEval commented May 3, 2023 •

edited

Loading

SiddheshKukade commented May 3, 2023

palisadoes commented May 14, 2023

SiddheshKukade commented May 14, 2023

palisadoes commented May 31, 2023

literalEval commented May 31, 2023

SiddheshKukade commented May 31, 2023

github-actions bot commented Jun 11, 2023

palisadoes commented Jun 11, 2023

palisadoes commented Jun 11, 2023

SiddheshKukade commented Jun 11, 2023

SiddheshKukade commented Jun 16, 2023 •

edited

Loading

noman2002 left a comment •

edited

Loading

noman2002 Jul 25, 2023

SiddheshKukade Jul 25, 2023

Bug Fix: Adding back the plugin architecture logic for talawa app #1778

Bug Fix: Adding back the plugin architecture logic for talawa app #1778

Conversation

SiddheshKukade commented Apr 14, 2023 • edited Loading

github-actions bot commented Apr 14, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

literalEval commented Apr 14, 2023

palisadoes commented Apr 14, 2023

SiddheshKukade commented Apr 14, 2023

SiddheshKukade commented May 3, 2023

palisadoes commented May 3, 2023

literalEval commented May 3, 2023

SiddheshKukade commented May 3, 2023

literalEval commented May 3, 2023 • edited Loading

SiddheshKukade commented May 3, 2023

palisadoes commented May 14, 2023

SiddheshKukade commented May 14, 2023

palisadoes commented May 31, 2023

literalEval commented May 31, 2023

SiddheshKukade commented May 31, 2023

github-actions bot commented Jun 11, 2023

palisadoes commented Jun 11, 2023

palisadoes commented Jun 11, 2023

SiddheshKukade commented Jun 11, 2023

SiddheshKukade commented Jun 16, 2023 • edited Loading

noman2002 left a comment • edited Loading

Choose a reason for hiding this comment

noman2002 Jul 25, 2023

Choose a reason for hiding this comment

SiddheshKukade Jul 25, 2023

Choose a reason for hiding this comment

SiddheshKukade commented Apr 14, 2023 •

edited

Loading

literalEval commented May 3, 2023 •

edited

Loading

SiddheshKukade commented Jun 16, 2023 •

edited

Loading

noman2002 left a comment •

edited

Loading