Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GSoC]Feature request: Add Hashtag feature for a post #2051

Conversation

Ayush0Chaudhary
Copy link
Contributor

What kind of change does this PR introduce?
add the tag feature

Issue Number:

Fixes #2050

Did you add tests for your changes?
yes

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Does this PR introduce a breaking change?

Other information

Have you read the contributing guide?
yes

@github-actions
Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/hashtag branch from 5a85b59 to 64701a7 Compare October 11, 2023 16:39

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/hashtag branch from 64701a7 to b5a774a Compare October 11, 2023 16:41
Copy link
Member

@noman2002 noman2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the failing test.

@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/hashtag branch from a875ae3 to 8af813f Compare October 18, 2023 18:56
@Ayush0Chaudhary Ayush0Chaudhary force-pushed the Ayush0Chaudhary/hashtag branch from 87c8e69 to 659825e Compare October 18, 2023 19:55
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #2051 (8325f72) into develop (4eadea5) will increase coverage by 0.03%.
Report is 9 commits behind head on develop.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##           develop    #2051      +/-   ##
===========================================
+ Coverage    76.62%   76.65%   +0.03%     
===========================================
  Files          151      152       +1     
  Lines         7370     7570     +200     
===========================================
+ Hits          5647     5803     +156     
- Misses        1723     1767      +44     
Files Coverage Δ
...dels/add_post_view_models/add_post_view_model.dart 68.51% <100.00%> (+0.59%) ⬆️
lib/views/after_auth_screens/add_post_page.dart 98.70% <100.00%> (+0.45%) ⬆️
lib/widgets/post_detailed_page.dart 100.00% <100.00%> (ø)

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

noman2002
noman2002 previously approved these changes Oct 19, 2023
@palisadoes
Copy link
Contributor

@Ayush0Chaudhary Please get the code coverage for the new files up to that of the repo.

@Ayush0Chaudhary
Copy link
Contributor Author

@palisadoes

@palisadoes palisadoes merged commit c2183d6 into PalisadoesFoundation:develop Oct 27, 2023
palisadoes pushed a commit to palisadoes/talawa that referenced this pull request Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[GSoC]Feature request: Add Hashtag feature for a post
3 participants