-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[GSoC]Feature request: Add Hashtag feature for a post #2051
[GSoC]Feature request: Add Hashtag feature for a post #2051
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
5a85b59
to
64701a7
Compare
64701a7
to
b5a774a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the failing test.
a875ae3
to
8af813f
Compare
8af813f
to
1629136
Compare
27a554d
to
87c8e69
Compare
87c8e69
to
659825e
Compare
Codecov Report
@@ Coverage Diff @@
## develop #2051 +/- ##
===========================================
+ Coverage 76.62% 76.65% +0.03%
===========================================
Files 151 152 +1
Lines 7370 7570 +200
===========================================
+ Hits 5647 5803 +156
- Misses 1723 1767 +44
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
@Ayush0Chaudhary Please get the code coverage for the new files up to that of the repo. |
…dation#2051) * HashTag feature implemented * chore: Add test
What kind of change does this PR introduce?
add the tag feature
Issue Number:
Fixes #2050
Did you add tests for your changes?
yes
Snapshots/Videos:
If relevant, did you update the documentation?
Summary
Does this PR introduce a breaking change?
Other information
Have you read the contributing guide?
yes