bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. #2079

Azad99-9 · 2023-10-30T08:24:59Z

What kind of change does this PR introduce?

bug fix: bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2.

Issue Number:

Fixes #2075

Did you add tests for your changes?

No

Snapshots/Videos:

If relevant, did you update the documentation?

Summary

Actually this #2075 issue required updation of all references of flutter_reaction_button package in the entire code base

Does this PR introduce a breaking change?

No

Other information

Have you read the contributing guide?

Yes

github-actions · 2023-10-30T08:25:39Z

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

The overall code coverage drops below the target threshold of the repository
Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

comments in this PR or
our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

arbitrators of future discussions with other contributors about the validity of your changes
point of contact for evaluating the validity of your work
person who verifies matching issues by others that should be closed.
person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

github-actions

Congratulations on making your first PR! 🎊 If you haven't already, check out our Contributing Guidelines and PR Reporting Guidelines to ensure that you are following our guidelines for contributing and creating PR.

palisadoes · 2023-10-30T17:33:06Z

Please fix the failing test

Azad99-9 · 2023-10-30T21:12:11Z

Please fix the failing test

files pubspec.yaml and pubspec.lock are listed in the unauthorized files.
In order to update the flutter_reaction_button package, editing of the files pubspec.yaml and pubspec.lock is required.

please have a look and help me with what can be done to pass the respective test.

palisadoes · 2023-10-30T21:34:03Z

Please fix the failing test

files pubspec.yaml and pubspec.lock are listed in the unauthorized files. In order to update the flutter_reaction_button package, editing of the files pubspec.yaml and pubspec.lock is required.

please have a look and help me with what can be done to pass the respective test.

Accessing the authorized files is understood. You need to fix this error:

https://github.com/PalisadoesFoundation/talawa/actions/runs/6690122715/job/18194444712?pr=2079

Azad99-9 · 2023-10-31T07:36:06Z

Please fix the failing test

files pubspec.yaml and pubspec.lock are listed in the unauthorized files. In order to update the flutter_reaction_button package, editing of the files pubspec.yaml and pubspec.lock is required.
please have a look and help me with what can be done to pass the respective test.

Accessing the authorized files is understood. You need to fix this error:

https://github.com/PalisadoesFoundation/talawa/actions/runs/6690122715/job/18194444712?pr=2079

Yeah, understood.

Ayush0Chaudhary · 2023-11-05T11:23:11Z

@Azad99-9 can you post video-rec of the reaction button?

Ayush0Chaudhary

Don't downgrade other packages.

pubspec.lock

Azad99-9 · 2023-11-05T17:55:19Z

@Azad99-9 can you post video-rec of the reaction button?

screen-20231105-182851.mp4

video of reaction button.

palisadoes · 2023-11-10T15:19:19Z

Please fix the failing test

Ayush0Chaudhary · 2023-11-10T16:29:22Z

Test are failing, fix them please!

Azad99-9 · 2023-11-12T16:14:22Z

@palisadoes @Ayush0Chaudhary
I have worked on fixing the failing tests and i found out that, the test file that is failing has following lines of code:
await Hive.openBox<User>('currentUser');
await Hive.openBox<OrgInfo>('currentOrg');
await Hive.openBox('url');
these lines does not impact the actual test logic in that file : talawa/test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart.

So i tried removing those lines and ran the tests and all the tests were passing.
Shall i commit the changes that were made to the test file.

Ayush0Chaudhary · 2023-11-14T03:23:55Z

@palisadoes @Ayush0Chaudhary
I have worked on fixing the failing tests and i found out that, the test file that is failing has following lines of code:
await Hive.openBox<User>('currentUser');
await Hive.openBox<OrgInfo>('currentOrg');
await Hive.openBox('url');
these lines does not impact the actual test logic in that file : talawa/test/widget_tests/after_auth_screens/app_settings/app_setting_page_test.dart.

So i tried removing those lines and ran the tests and all the tests were passing.
Shall i commit the changes that were made to the test file.

Yes

codecov · 2023-11-14T05:59:51Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (c2cfa97) 76.39% compared to head (d723800) 76.17%.
Report is 4 commits behind head on develop.

❗ Current head d723800 differs from pull request most recent head aa208d9. Consider uploading reports for the commit aa208d9 to get more accurate results

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #2079      +/-   ##
===========================================
- Coverage    76.39%   76.17%   -0.22%     
===========================================
  Files          152      152              
  Lines         7442     7442              
===========================================
- Hits          5685     5669      -16     
- Misses        1757     1773      +16

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

…ting additional tests.

noman2002 · 2023-11-17T17:24:54Z

@Azad99-9 Please fix the conflicting files.

Azad99-9 · 2023-11-17T19:40:34Z

@noman2002 Please advise on resolving the 'unauthorized files' error.

palisadoes · 2023-11-17T20:07:05Z

@noman2002 Please advise on resolving the 'unauthorized files' error.

The test is failing because you have edited one or more files that we more carefully track to reduce the risk of breaking our GitHub action workflows and other related automation. This is to be expected in certain types of PRs especially those that alter the packages required by the repo’s app.

Azad99-9 · 2023-11-18T05:27:14Z

Please fix the failing test

files pubspec.yaml and pubspec.lock are listed in the unauthorized files. In order to update the flutter_reaction_button package, editing of the files pubspec.yaml and pubspec.lock is required.

please have a look and help me with what can be done to pass the respective test.

@palisadoes please have a look at this.

noman2002

Looks good to me.

…oundation#2079) * bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. * added required fields for the widget * formatted firebase options * upgraded the previously downgraded packages * undoing build.gradle change * fixed failing test * increased codecoverage of multi_reaction.dart from 94% to 100% by writing additional tests. * formatted the changes. * resolved conflict code * fixed failing tests * fixed failing tests

Azad99-9 and others added 2 commits October 30, 2023 13:47

bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2.

79db153

Merge branch 'PalisadoesFoundation:develop' into develop

b41d0ec

github-actions bot reviewed Oct 30, 2023

View reviewed changes

Azad99-9 and others added 2 commits November 3, 2023 15:34

Merge branch 'PalisadoesFoundation:develop' into develop

fe134ca

added required fields for the widget

8fd5668

palisadoes requested review from Ayush0Chaudhary and literalEval November 4, 2023 16:30

formatted firebase options

a4e4a53

Ayush0Chaudhary requested changes Nov 5, 2023

View reviewed changes

pubspec.lock Show resolved Hide resolved

pubspec.lock Outdated Show resolved Hide resolved

pubspec.lock Outdated Show resolved Hide resolved

Azad99-9 added 2 commits November 5, 2023 18:39

upgraded the previously downgraded packages

c8ee88c

undoing build.gradle change

e7c4811

Azad99-9 requested a review from Ayush0Chaudhary November 6, 2023 17:58

Merge branch 'PalisadoesFoundation:develop' into develop

eb2a6ce

fixed failing test

94dfd40

Azad99-9 and others added 3 commits November 14, 2023 15:29

Merge branch 'PalisadoesFoundation:develop' into develop

d723800

increased codecoverage of multi_reaction.dart from 94% to 100% by wri…

523f4c7

…ting additional tests.

formatted the changes.

7feac90

Azad99-9 added 3 commits November 18, 2023 00:15

resolved conflict code

cb9795d

fixed failing tests

b436257

fixed failing tests

aa208d9

noman2002 approved these changes Nov 18, 2023

View reviewed changes

palisadoes approved these changes Nov 18, 2023

View reviewed changes

palisadoes merged commit 4603ad1 into PalisadoesFoundation:develop Nov 18, 2023
5 of 6 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. #2079

bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. #2079

Azad99-9 commented Oct 30, 2023 •

edited

Loading

github-actions bot commented Oct 30, 2023

github-actions bot left a comment

palisadoes commented Oct 30, 2023

Azad99-9 commented Oct 30, 2023

palisadoes commented Oct 30, 2023

Azad99-9 commented Oct 31, 2023

Ayush0Chaudhary commented Nov 5, 2023

Ayush0Chaudhary left a comment •

edited

Loading

Azad99-9 commented Nov 5, 2023

palisadoes commented Nov 10, 2023

Ayush0Chaudhary commented Nov 10, 2023

Azad99-9 commented Nov 12, 2023 •

edited

Loading

Ayush0Chaudhary commented Nov 14, 2023

codecov bot commented Nov 14, 2023 •

edited

Loading

noman2002 commented Nov 17, 2023

Azad99-9 commented Nov 17, 2023

palisadoes commented Nov 17, 2023

Azad99-9 commented Nov 18, 2023

noman2002 left a comment

bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. #2079

bumped up flutter_reaction_button from 2.0.2 to 3.0.0+2. #2079

Conversation

Azad99-9 commented Oct 30, 2023 • edited Loading

github-actions bot commented Oct 30, 2023

Our Pull Request Approval Process

Testing Your Code

Reviewers

Reviewing Your Code

Other

github-actions bot left a comment

Choose a reason for hiding this comment

palisadoes commented Oct 30, 2023

Azad99-9 commented Oct 30, 2023

palisadoes commented Oct 30, 2023

Azad99-9 commented Oct 31, 2023

Ayush0Chaudhary commented Nov 5, 2023

Ayush0Chaudhary left a comment • edited Loading

Choose a reason for hiding this comment

Azad99-9 commented Nov 5, 2023

palisadoes commented Nov 10, 2023

Ayush0Chaudhary commented Nov 10, 2023

Azad99-9 commented Nov 12, 2023 • edited Loading

Ayush0Chaudhary commented Nov 14, 2023

codecov bot commented Nov 14, 2023 • edited Loading

Codecov Report

noman2002 commented Nov 17, 2023

Azad99-9 commented Nov 17, 2023

palisadoes commented Nov 17, 2023

Azad99-9 commented Nov 18, 2023

noman2002 left a comment

Choose a reason for hiding this comment

Azad99-9 commented Oct 30, 2023 •

edited

Loading

Ayush0Chaudhary left a comment •

edited

Loading

Azad99-9 commented Nov 12, 2023 •

edited

Loading

codecov bot commented Nov 14, 2023 •

edited

Loading