-
-
Notifications
You must be signed in to change notification settings - Fork 496
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unit test for services post_services.dart #2244
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersWhen your PR has been assigned reviewers contact them to get your code reviewed and approved via:
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix the failing tests.
@noman2002 sir, as soon as i remove |
Hello @PraminBudhathoki, there are certain linting checks in Talwa in order to maintain the proper code format so that the good practice of writing code in a proper formatted way such that it should be understandable by all the current and future contributors remains maintained.
You could get the proper doc format for the methods which shows linting errors by pressing I hope this helped you a little, do hit me up or in #talawa-mobile channel on slack if you need any further help. |
@Dante291 ok i will fix it . Thanks. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2244 +/- ##
===========================================
+ Coverage 80.08% 80.73% +0.64%
===========================================
Files 149 149
Lines 6966 7006 +40
===========================================
+ Hits 5579 5656 +77
+ Misses 1387 1350 -37 ☔ View full report in Codecov by Sentry. |
* Added unit_tests for post_service.dart * Formatted the updated test code * Fix lint issues in post_service.dart * formatted the modified dart files * fixed error after running flutter analyze * fixed error after running flutter analyze * modified * formatted the code * modified
What kind of change does this PR introduce?
This change included the Unit test for service post_service.dart
Issue Number:#2160
Fixes #2160
Did you add tests for your changes?
Yes, I have added tests.
Does this PR introduce a breaking change?
No, this does not involve major changes to the codebase.
Have you read the contributing guide?
Yes, I have followed the contribution guideline.