-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixed fetch post by org #2414
fixed fetch post by org #2414
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2414 +/- ##
========================================
Coverage 96.25% 96.25%
========================================
Files 152 152
Lines 7524 7578 +54
========================================
+ Hits 7242 7294 +52
- Misses 282 284 +2 ☔ View full report in Codecov by Sentry. |
@AVtheking Please fix the failing codecov tests. |
…nto fix/postbyOrg
@Cioppolo14 I have fixed failing codecov tests. |
Tests are failing |
I have fixed failing test ,please assign reviewers . |
@Ayush0Chaudhary I have made changes requested by you please review. |
@AVtheking Having a button to move to next page is not a good approach in a feed like structure. Please do it without the buttons. |
Ok will look into it,are you talking about scrolling approach? |
…nto fix/postbyOrg
@noman2002 this http error is still showing ,can we merge this and open issue write test for this ? As this funcitonality needs to be resolved |
This is an update on the PR merging freeze:
We decided to do this at the beginning of the weekend to give us all time to adjust PR code and create bug fixes that may arise. Update your code at or after midnight GMT on the morning of March 23, 2024. (5:30am IST). If your PRs have already been approved, request a re-review after fixing the conflicts and refactoring to the new |
Please work with @Azad99-9 and get this fixed in this PR. |
@AVtheking please check the app is failing to build. |
@Azad99-9 i have tried building it in my local it is working fine,what could be the reason of this fail? |
Have you downgraded any packages ? |
No just merged with latest upstream |
If you didn't downgrade any packages then It might be a transient bug. Please do a minor commit and try to rebuild the app. |
@AVtheking I have solved the HTTP bug for this issue. please do the below-suggested code changes. You will be good to go. |
The reason for the bug was:
As mentioned after doing this the HTTP bug has implicitly I have only solved the HTTP bug and made the test run successfully. You please cover all the remaining lines by writing tests to all possible situations to cover the if blocks in Feel free to reach out to me if you need any more futher assistance. Thank you. |
@Azad99-9 Thanks ,I would try this. |
please review this PR. |
0b4e291
into
PalisadoesFoundation:develop
What kind of change does this PR introduce?
Changed postByOrganization query according to new paginatied query in the api.
Issue Number:
Fixes #2404
Did you add tests for your changes?
Yes
Video
Recording.2024-03-15.003418.mp4