-
-
Notifications
You must be signed in to change notification settings - Fork 504
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Error in Event Creation & Update with latest recurrence changes #2481
Fixed Error in Event Creation & Update with latest recurrence changes #2481
Conversation
Our Pull Request Approval ProcessWe have these basic policies to make the approval process smoother for our volunteer team. Testing Your CodePlease make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:
The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing. ReviewersDo not assign reviewers. Our Queue Monitors will review your PR and assign them.
Reviewing Your CodeYour reviewer(s) will have the following roles:
Other🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise. |
@GlenDsza Please fix the failing test. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #2481 +/- ##
===========================================
+ Coverage 96.50% 96.61% +0.11%
===========================================
Files 154 155 +1
Lines 7777 7898 +121
===========================================
+ Hits 7505 7631 +126
+ Misses 272 267 -5 ☔ View full report in Codecov by Sentry. |
@GlenDsza Could you parse the date format into DD/MM/YYYY as that is more readable format and more user friendly also there is lot of space for date to be in a single line and not in multiple lines so please fix that too |
Please also get the code test coverage higher |
Sorry for Delay, had exams past week, working on it (wip) |
What kind of change does this PR introduce?
bugfix, feature, refactoring
Issue Number:
Fixes #2468
Did you add tests for your changes?
Yes
Snapshots/Videos:
recurrence_events.mp4
Summary
Does this PR introduce a breaking change?
No.
Other information
No. of files changed is large as had to make minor changes in unrelated files due to generating new test_helper_mocks via mockito.
Have you read the contributing guide?
Yes