Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed Error in Event Creation & Update with latest recurrence changes #2481

Merged
merged 18 commits into from
May 3, 2024

Conversation

GlenDsza
Copy link
Contributor

What kind of change does this PR introduce?

bugfix, feature, refactoring

Issue Number:

Fixes #2468

Did you add tests for your changes?

Yes

Snapshots/Videos:

recurrence_events.mp4

Summary

  • Remove latitude, longitude, recurrance deprecated fields from events and updated query.
  • Added support for latest recurrence changes made in feat: Recurring events improvements and additions talawa-api#2234
  • Added dynamic recurrence labels in dropdown as well as custom monthly recurrence
  • Generated new test_helper_mocks (mockito)
  • Update Create event model to remove unused fields.
  • Updated test cases & Added docs for modified files.

Does this PR introduce a breaking change?

No.

Other information

No. of files changed is large as had to make minor changes in unrelated files due to generating new test_helper_mocks via mockito.

Have you read the contributing guide?

Yes

Copy link

Our Pull Request Approval Process

We have these basic policies to make the approval process smoother for our volunteer team.

Testing Your Code

Please make sure your code passes all tests. Our test code coverage system will fail if either of these two conditions occur:

  1. The overall code coverage drops below the target threshold of the repository
  2. Any file in the pull request has code coverage levels below the repository threshold

The process helps maintain the overall reliability of the code base and is a prerequisite for getting your PR approved. Assigned reviewers regularly review the PR queue and tend to focus on PRs that are passing.

Reviewers

Do not assign reviewers. Our Queue Monitors will review your PR and assign them.
When your PR has been assigned reviewers contact them to get your code reviewed and approved via:

  1. comments in this PR or
  2. our slack channel

Reviewing Your Code

Your reviewer(s) will have the following roles:

  1. arbitrators of future discussions with other contributors about the validity of your changes
  2. point of contact for evaluating the validity of your work
  3. person who verifies matching issues by others that should be closed.
  4. person who gives general guidance in fixing your tests

Other

🎯 Please be considerate of our volunteers' time. Contacting the person who assigned the reviewers is not advised unless they ask for your input. Do not @ the person who did the assignment otherwise.

@Cioppolo14
Copy link
Contributor

@GlenDsza Please fix the failing test.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.61%. Comparing base (24f4aa7) to head (9e74a25).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2481      +/-   ##
===========================================
+ Coverage    96.50%   96.61%   +0.11%     
===========================================
  Files          154      155       +1     
  Lines         7777     7898     +121     
===========================================
+ Hits          7505     7631     +126     
+ Misses         272      267       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Dante291
Copy link
Contributor

@GlenDsza Could you parse the date format into DD/MM/YYYY as that is more readable format and more user friendly also there is lot of space for date to be in a single line and not in multiple lines so please fix that too

image

@palisadoes
Copy link
Contributor

Please also get the code test coverage higher

@GlenDsza
Copy link
Contributor Author

GlenDsza commented Apr 28, 2024

Sorry for Delay, had exams past week, working on it (wip)

@palisadoes palisadoes added the wip Work in Progress label Apr 28, 2024
@palisadoes palisadoes requested a review from Ayush0Chaudhary May 2, 2024 12:31
@palisadoes palisadoes merged commit 55aa344 into PalisadoesFoundation:develop May 3, 2024
10 checks passed
@GlenDsza GlenDsza deleted the event_creation branch May 4, 2024 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wip Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error in Event Creation & Fetch due to Faulty mutation
4 participants