-
-
Notifications
You must be signed in to change notification settings - Fork 497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix] User can delete any event (Front-end) #842
[Fix] User can delete any event (Front-end) #842
Conversation
I'm thinking Users shouldn't even see an option to delete if they are unable to, |
@TheHazeEffect, @AdityaBirangal Yes, that's true. The additional security of them not being able to do it in the API is going to be added. I'll open a bug issue for that. The option should be removed in the app like you said. |
@AdityaBirangal could you go ahead and hide the button for those who are unable to delete? |
It will be good as per users perspective if he/she didn't see an option to delete if he/she is not allowed. I did required changes @TheHazeEffect |
@Sagar2366 @DeltaHarbinger Please take a look. |
Done 👍🏻 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Resolves Issue #832 for the Mobile application
Ready to be merged
I believe work still needs to be done to check user permission level in the api
to protect against direct requests, Probably best done by checking user's permission level by token.
Yeah. |
What kind of change does this PR introduce?
fix #832
Did you add tests for your changes?
No
If relevant, did you update the documentation?
Not required
Summary
Front-end (Flutter) part fixed
Back-end (API) will be get fixed in PalisadoesFoundation/talawa-api#261
Does this PR introduce a breaking change?
Nope
Other information
Github Externship Appication No. :
20-05_Adi500_tfa_262