Skip to content
This repository has been archived by the owner on Jun 14, 2023. It is now read-only.

Module ipv4 proxyid for ipsec tunnel #380

Merged
merged 5 commits into from
Jun 6, 2019

Conversation

odysseus107
Copy link
Contributor

New module regarding issue #375

Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok... most of my feedback is small changes, but this is some seriously awesome work on this!

library/panos_ipsec_ipv4_proxyid.py Outdated Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Outdated Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Outdated Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there on this, just one miss from last time and one new thing (line removal).

library/panos_ipsec_ipv4_proxyid.py Outdated Show resolved Hide resolved
library/panos_ipsec_ipv4_proxyid.py Show resolved Hide resolved
Copy link
Collaborator

@shinmog shinmog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, thanks for all the work on this!

@shinmog shinmog merged commit 88ce811 into PaloAltoNetworks:develop Jun 6, 2019
shinmog added a commit that referenced this pull request Jun 11, 2019
* Declare module encoding

* adding function to turn pandevice objects to dicts

* adding panos_zone_facts

* Module ipv4 proxyid for ipsec tunnel (#380)

* Added module panos_ipsec_ipv4_proxyid

* Fixed test build problem

* Applied changes requested by @shinmog

* Fix build problem

* Additionally requested changes by @shinmog

* adding panos_virtual_router_facts (#383)

* fixing RETURNS section

* adding panos_l3_subinterface (#384)

* Correcting example documentation

* adding panos_l2_subinterface (#385)

* Policy facts details (#376)

* Updated documentation for security_rule_facts

* Documentation re-built

* Get full details when querying all rules using 'all_details: yes' argument

* Small fixes to panos_security_rule_facts

* Bug fixes panos_security_rule_facts.py

* Fixup for hyphens/dashes with extra bytes (#387)

* Adding param: 'vsys_shared' (#388)

* adding support for log forwarding profiles (#391)

* adding support for log forwarding profiles

* fixing code style issue

* adding support for email profiles (#389)

* adding support for snmp profiles (#392)

* adding support for syslog profiles (#393)

* adding support for syslog profiles

* fixing code style issue

* adding support for http profiles (#390)

* correcting arg to vsys_shared

* adding panos_type_cmd (#394)

* Updating to 2.2.0 (#395)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants