[Bug Fix] SchemaTabs: Cannot read properties of undefined #160

blindaa121 · 2022-07-14T21:03:09Z

Description

Added additional condition for creating TabItem component when handling allOf schemas in createAnyOneOf utils. Currently, we have support for checking the following:

schema.properties
schema.allOf

In cases where anyOneOf contains schema.items, the SchemaTabs component would fail to render due to a return value of undefined.

Code Security - Get Repository Name

Code Security - Fix or Suppress Scan Results

Motivation and Context

Expected behavior should be able to render SchemaTabs without breaking any pages.

How Has This Been Tested?

Tested with Code Security API and ensured all OpenAPI pages loaded successfully and SchemaTabs rendered the appropriate schema.

Screenshots (if appropriate)

Code Security - Get Repository Name

Code Security - Fix or Suppress Scan Results

Screen.Recording.2022-07-14.at.2.02.06.PM.mov

Types of changes

Bug fix (non-breaking change which fixes an issue)

Checklist

I have updated the documentation accordingly.
I have read the CONTRIBUTING document.
I have added tests to cover my changes if appropriate.
All new and existing tests passed.

github-actions · 2022-07-14T21:06:54Z

Size Change: -40.7 kB (-1%)

Total Size: 3.44 MB

Filename	Size	Change
`demo/build/assets/js/06e5f0f0.********.js`	26.4 kB	-118 B (0%)
`demo/build/assets/js/112df51d.********.js`	24.1 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/16ed3e0d.********.js`	23.6 kB	-1.47 kB (-6%)	✅
`demo/build/assets/js/1e71f858.********.js`	23.6 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/1f3711ab.********.js`	24 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/21b83554.********.js`	9.83 kB	+40 B (0%)
`demo/build/assets/js/25b7fcf3.********.js`	21.6 kB	+288 B (+1%)
`demo/build/assets/js/2610c6ee.********.js`	16.3 kB	-848 B (-5%)	✅
`demo/build/assets/js/2b60538e.********.js`	21.5 kB	+288 B (+1%)
`demo/build/assets/js/2da0bfe8.********.js`	24 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/2ee3fbbb.********.js`	10.9 kB	+33 B (0%)
`demo/build/assets/js/36675a4b.********.js`	30.2 kB	-1.69 kB (-5%)	✅
`demo/build/assets/js/374f9103.********.js`	14.5 kB	-424 B (-3%)
`demo/build/assets/js/4964e910.********.js`	22.9 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/49d625b5.********.js`	23.5 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/4bdd3fbe.********.js`	14.4 kB	-424 B (-3%)
`demo/build/assets/js/6102b0bc.********.js`	30.3 kB	-1.69 kB (-5%)	✅
`demo/build/assets/js/64ad353b.********.js`	24 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/6b63c616.********.js`	23.9 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/6dbe9da1.********.js`	23.7 kB	-1.47 kB (-6%)	✅
`demo/build/assets/js/7933a256.********.js`	24.2 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/7a7d82e8.********.js`	23.4 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/835a9617.********.js`	11 kB	+33 B (0%)
`demo/build/assets/js/8463bcfe.********.js`	21.6 kB	+288 B (+1%)
`demo/build/assets/js/892ce721.********.js`	24 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/935b44fb.********.js`	16.4 kB	-848 B (-5%)	✅
`demo/build/assets/js/97810f3c.********.js`	22.9 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/9c58e5d3.********.js`	22.1 kB	+288 B (+1%)
`demo/build/assets/js/9e2a7edc.********.js`	30.2 kB	-1.69 kB (-5%)	✅
`demo/build/assets/js/b8b62e90.********.js`	23.6 kB	-1.47 kB (-6%)	✅
`demo/build/assets/js/bceea4ca.********.js`	9.77 kB	+40 B (0%)
`demo/build/assets/js/bf9a5101.********.js`	23.9 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/c2838c41.********.js`	23.4 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/c2b8341d.********.js`	23.5 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/c5c41c27.********.js`	23.5 kB	-1.7 kB (-7%)	✅
`demo/build/assets/js/dbf42779.********.js`	16.5 kB	-848 B (-5%)	✅
`demo/build/assets/js/dd696920.********.js`	22.8 kB	-1.69 kB (-7%)	✅
`demo/build/assets/js/e165a18a.********.js`	11 kB	+33 B (0%)
`demo/build/assets/js/e65a1271.********.js`	14.5 kB	-424 B (-3%)
`demo/build/assets/js/eff95040.********.js`	24.1 kB	-1.48 kB (-6%)	✅
`demo/build/assets/js/f30e634b.********.js`	22.2 kB	+288 B (+1%)
`demo/build/assets/js/fdd24af5.********.js`	9.65 kB	+40 B (0%)
`demo/build/assets/js/ffc99614.********.js`	22.2 kB	+288 B (+1%)

ℹ️ View Unchanged

Filename	Size	Change
`demo/.docusaurus/globalData.json`	20.2 kB	0 B
`demo/build/assets/css/styles.********.css`	95.6 kB	0 B
`demo/build/assets/js/05f64ae1.********.js`	2.8 kB	0 B
`demo/build/assets/js/06b64fc1.********.js`	575 B	0 B
`demo/build/assets/js/081bfb0d.********.js`	9.53 kB	0 B
`demo/build/assets/js/09e07b87.********.js`	3 kB	0 B
`demo/build/assets/js/14eb3368.********.js`	9.33 kB	0 B
`demo/build/assets/js/1639936b.********.js`	4.05 kB	0 B
`demo/build/assets/js/16577668.********.js`	387 B	0 B
`demo/build/assets/js/1676ff52.********.js`	9.89 kB	0 B
`demo/build/assets/js/18c41134.********.js`	12.7 kB	0 B
`demo/build/assets/js/1be78505.********.js`	10.3 kB	0 B
`demo/build/assets/js/1e4232ab.********.js`	3.15 kB	0 B
`demo/build/assets/js/1f818248.********.js`	10.4 kB	0 B
`demo/build/assets/js/2a3d8b7d.********.js`	11.4 kB	-18 B (0%)
`demo/build/assets/js/2c860537.********.js`	6.38 kB	0 B
`demo/build/assets/js/326c3861.********.js`	9.59 kB	0 B
`demo/build/assets/js/3893.********.js`	1.07 kB	0 B
`demo/build/assets/js/39d00f16.********.js`	9.45 kB	0 B
`demo/build/assets/js/46afcded.********.js`	8.13 kB	0 B
`demo/build/assets/js/46e5c6ac.********.js`	6.66 kB	0 B
`demo/build/assets/js/47abaca6.********.js`	2.9 kB	0 B
`demo/build/assets/js/4851c287.********.js`	10.9 kB	0 B
`demo/build/assets/js/4c5e977b.********.js`	30.9 kB	0 B
`demo/build/assets/js/52efb675.********.js`	9.83 kB	0 B
`demo/build/assets/js/533a09ca.********.js`	2.48 kB	0 B
`demo/build/assets/js/55b55784.********.js`	8.51 kB	0 B
`demo/build/assets/js/56717cba.********.js`	2.96 kB	0 B
`demo/build/assets/js/58ff8b1e.********.js`	20.4 kB	0 B
`demo/build/assets/js/5c868d36.********.js`	3.24 kB	0 B
`demo/build/assets/js/5fb917be.********.js`	2.56 kB	0 B
`demo/build/assets/js/6429.********.js`	1.29 MB	0 B
`demo/build/assets/js/6eec44b8.********.js`	8.57 kB	0 B
`demo/build/assets/js/71f1585f.********.js`	11 kB	0 B
`demo/build/assets/js/7633a546.********.js`	9.71 kB	0 B
`demo/build/assets/js/822bd8ab.********.js`	2.87 kB	0 B
`demo/build/assets/js/840731c0.********.js`	10.3 kB	0 B
`demo/build/assets/js/85d3c400.********.js`	2.9 kB	0 B
`demo/build/assets/js/85ec4403.********.js`	3.9 kB	0 B
`demo/build/assets/js/86c346b0.********.js`	538 B	0 B
`demo/build/assets/js/881db345.********.js`	394 B	0 B
`demo/build/assets/js/8ab9b16e.********.js`	9.34 kB	0 B
`demo/build/assets/js/8d4e78cd.********.js`	2.81 kB	0 B
`demo/build/assets/js/8f441c78.********.js`	9.55 kB	0 B
`demo/build/assets/js/93304a97.********.js`	4.17 kB	0 B
`demo/build/assets/js/935f2afb.********.js`	35.2 kB	0 B
`demo/build/assets/js/a5491aaa.********.js`	392 B	0 B
`demo/build/assets/js/a6cd895f.********.js`	20.2 kB	0 B
`demo/build/assets/js/a6f84189.********.js`	11.5 kB	-18 B (0%)
`demo/build/assets/js/a728d93a.********.js`	9.46 kB	0 B
`demo/build/assets/js/ab09fd5c.********.js`	20.3 kB	0 B
`demo/build/assets/js/bead4b8e.********.js`	3.05 kB	0 B
`demo/build/assets/js/bf271e74.********.js`	393 B	0 B
`demo/build/assets/js/c7ded1cb.********.js`	2.95 kB	0 B
`demo/build/assets/js/common.********.js`	141 kB	0 B
`demo/build/assets/js/d63c7029.********.js`	2.9 kB	0 B
`demo/build/assets/js/d69e68dd.********.js`	10.1 kB	0 B
`demo/build/assets/js/d90c1c35.********.js`	10.8 kB	0 B
`demo/build/assets/js/dff1c289.********.js`	3.88 kB	0 B
`demo/build/assets/js/e2ce9793.********.js`	426 B	0 B
`demo/build/assets/js/e44a2883.********.js`	4.53 kB	0 B
`demo/build/assets/js/e53a20a4.********.js`	11.6 kB	-18 B (0%)
`demo/build/assets/js/e5e5340c.********.js`	2.5 kB	0 B
`demo/build/assets/js/e6f78ab2.********.js`	8.47 kB	0 B
`demo/build/assets/js/e8b309fb.********.js`	577 B	0 B
`demo/build/assets/js/ecc39b49.********.js`	172 B	0 B
`demo/build/assets/js/f55d3e7a.********.js`	2.7 kB	0 B
`demo/build/assets/js/f8409a7e.********.js`	29.4 kB	0 B
`demo/build/assets/js/fcb807fc.********.js`	10.2 kB	0 B
`demo/build/assets/js/main.********.js`	400 kB	0 B
`demo/build/assets/js/runtime~main.********.js`	8.68 kB	0 B
`demo/build/index.html`	80 kB	0 B

_{compressed-size-action}

github-actions · 2022-07-14T21:10:57Z

Visit the preview URL for this PR (updated for commit c7a333d):

https://docusaurus-openapi-36b86--pr160-981t3jkf.web.app

_{(expires Thu, 18 Aug 2022 19:30:18 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

…reateItems support

sserrata

🦝

Add schema.items condition to create TabItem

e9ff838

blindaa121 requested a review from sserrata July 14, 2022 21:04

blindaa121 self-assigned this Jul 14, 2022

blindaa121 added the bug Something isn't working label Jul 14, 2022

sserrata added 14 commits July 14, 2022 17:17

Uncomment schema.items condition

f15b47d

Move createAnyOneOf to createSchemaDetails

9c66e3f

Comment out schema.items qualifier condition

aaa3fd0

Begin refactor to improve readability and simplify

5b88176

Add support for Schema array and additional edge cases

b98c2d3

Re-gen API docs

dfaf61c

Add support for array of objects

bd94cfb

Add support for nested anyOf/oneOf

da1852e

Add anyOf/oneOf support to createNodes

77f01fc

Fix additionalProperties type

a77a04f

Uncomment getQualifier for schema.items

4c6def9

Add support for additionalProperties and improve createAnyOneOf and c…

af32715

…reateItems support

Re-gen API docs

8fbde0c

Cleanup debugging

c1d0060

sserrata mentioned this pull request Jul 19, 2022

Module not found: Error: Can't resolve '@theme/DocItemFooter' #162

Closed

sserrata added 2 commits July 19, 2022 15:22

Extend support for additional primitives

3b99f33

Re-gen API docs

c7a333d

sserrata approved these changes Jul 19, 2022

View reviewed changes

sserrata merged commit 8ced842 into main Jul 19, 2022

sserrata deleted the schema-tabs-undefined-fix branch July 19, 2022 21:52

sserrata mentioned this pull request Jul 20, 2022

[Bug] Servers form component no longer appearing above code samples #166

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Bug Fix] SchemaTabs: Cannot read properties of undefined #160

[Bug Fix] SchemaTabs: Cannot read properties of undefined #160

blindaa121 commented Jul 14, 2022

github-actions bot commented Jul 14, 2022 •

edited

Loading

github-actions bot commented Jul 14, 2022 •

edited

Loading

sserrata left a comment

[Bug Fix] SchemaTabs: Cannot read properties of undefined #160

[Bug Fix] SchemaTabs: Cannot read properties of undefined #160

Conversation

blindaa121 commented Jul 14, 2022

Description

Code Security - Get Repository Name

Code Security - Fix or Suppress Scan Results

Motivation and Context

How Has This Been Tested?

Screenshots (if appropriate)

Code Security - Get Repository Name

Code Security - Fix or Suppress Scan Results

Types of changes

Checklist

github-actions bot commented Jul 14, 2022 • edited Loading

github-actions bot commented Jul 14, 2022 • edited Loading

sserrata left a comment

Choose a reason for hiding this comment

github-actions bot commented Jul 14, 2022 •

edited

Loading

github-actions bot commented Jul 14, 2022 •

edited

Loading