fix jsonSchemaMergeAllOf options in createRequestSchema #374
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🎉 Thanks for opening this pull request! We really appreciate contributors like you! 🙌 |
|
Visit the preview URL for this PR (updated for commit c0df3aa): https://docusaurus-openapi-36b86--pr374-k0ulthdj.web.app (expires Thu, 26 Jan 2023 12:41:23 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
|
Hi @98o718, thanks for the PR/fix! I am still not 100% clear on how this prevent some |
|
🎉 Congrats on getting your first pull request merged! We here at Palo Alto Networks are so grateful! ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The creation of a request schema works incorrectly. If there is a request body with allOf refs there will be no correct request body.
Motivation and Context
It will fix bug
Screenshots
Types of changes
Checklist