-
Notifications
You must be signed in to change notification settings - Fork 250
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for rendering additionalProperties schemas #465
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Visit the preview URL for this PR (updated for commit 7193b4a): https://docusaurus-openapi-36b86--pr465-e7s4g1o1.web.app (expires Thu, 30 Mar 2023 22:27:56 GMT) 🔥 via Firebase Hosting GitHub Action 🌎 |
Size Change: +420 B (0%) Total Size: 6.27 MB
ℹ️ View Unchanged
|
csestito
approved these changes
Feb 28, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
…lOf before returning createDetailsComponent
Merged
sserrata
added a commit
that referenced
this pull request
Mar 1, 2023
* Add support for rendering additionalProperties schemas * Check for properties, items, anyOf, oneOf, additionalProperties or allOf before returning createDetailsComponent * Add check for array
This was referenced Mar 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously, the plugin was only handling
additionalProperties
with no schema/properties defined, i.e. only atype
. This change introduces support for renderingadditionalProperties
schemas, e.g.properties
,items
, etc., when present.Motivation and Context
Expanded support for
additionalProperties
.How Has This Been Tested?
Tested with CSPM Anomalies API spec.
Screenshots (if appropriate)
Types of changes
Checklist