Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 2.3.0 support #471

Merged
merged 20 commits into from
Mar 2, 2023
Merged

Prepare 2.3.0 support #471

merged 20 commits into from
Mar 2, 2023

Conversation

sserrata
Copy link
Member

@sserrata sserrata commented Mar 1, 2023

Description

Docusurus 2.3.0 introduced a breaking change to Tabs component that will require a refactor of all custom tabs components defined in docusaurus-theme-openapi-docs. This is the working branch for the refactor.

The high-level plan is to:

  1. Begin with vanilla @theme/Tabs
  2. Replace or eliminate custom tabs with styled @theme/Tabs wherever possible
  3. Retain and refactor those custom tabs that require access to Redux
  • ApiTabs
  • CodeTabs
  • SchemaTabs
  • DiscriminatorTabs
  • MimeTabs

Note that this does not include changes from BEM-class refactor/cleanup

Motivation and Context

Addresses #396

@sserrata sserrata added this to the v2.0 UI/UX Refresh milestone Mar 1, 2023
@sserrata sserrata closed this Mar 1, 2023
@sserrata sserrata reopened this Mar 1, 2023
@sserrata sserrata changed the base branch from main to v2.0.0 March 1, 2023 14:11
@github-actions
Copy link

github-actions bot commented Mar 1, 2023

Visit the preview URL for this PR (updated for commit d42f35e):

https://docusaurus-openapi-36b86--pr471-yp6nr5x1.web.app

(expires Sat, 01 Apr 2023 23:12:58 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

@blindaa121 blindaa121 mentioned this pull request Mar 1, 2023
12 tasks
@sserrata sserrata requested a review from blindaa121 March 2, 2023 20:48
Copy link
Collaborator

@blindaa121 blindaa121 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🐐

@sserrata sserrata merged commit a1c831e into v2.0.0 Mar 2, 2023
@sserrata sserrata deleted the prepare-2.3.0-support branch March 10, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants