Add combat tracker API #11853
Open
Add combat tracker API #11853
+552
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
reviewed
Dec 29, 2024
Comment on lines
31
to
32
| * Mutating the list is safe and won't have | ||
| * an effect on this entity's combat history. |
There was a problem hiding this comment.
It should just be immutable/say it's a copy
There was a problem hiding this comment.
Updated the wording to state it's a copy.
Haven't made this immutable because it's returning a copy internally each time, so modifications are safe. Otherwise, users would need to make a copy of a copy.
| * @see #resetCombatState() | ||
| * @see #addCombatEntry(CombatEntry) | ||
| */ | ||
| void setCombatEntries(List<CombatEntry> combatEntries); |
There was a problem hiding this comment.
"Sneakily" setting prior combat history without overriding/resetting active combat state.
It's a neat shortcut for providing fake pre-made combat history scenarios and producing specific death messages.
paper-api/src/main/java/io/papermc/paper/world/damagesource/FallLocation.java
Outdated
Show resolved
Hide resolved
- Rename FallLocation to FallLocationType - Change CombatTracker#getCombatEntries javadoc
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
LivingEntity#getCombatTrackerto get entity's combat tracker that allows getting/setting combat history (list of damage entries during a combat session), recording new combat entries without causing actual damage, getting/resetting current combat state/session and getting a death message based on the present combat history.FallLocationrepresents a location from which the entity fell, and is used by vanilla to generate fall death messages.API implementation is basically done, but definitely open to feedback. Javadocs & namings could use some love.