Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

checkstyle configuration for API #11859

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

checkstyle configuration for API #11859

wants to merge 17 commits into from

Conversation

Machine-Maker
Copy link
Member

@Machine-Maker Machine-Maker commented Dec 29, 2024

The checkstyle configuration for the API. The server's will come later and be mostly similar with some key differences (like javadocs and excluding decompiled sources).

Has a file that includes all packages in the API that need to be done. Once removed from that list, all files in it will be subject to checkstyle.

Checkstyle Categories

Preview Give feedback

@Machine-Maker Machine-Maker added the status: input wanted Looking for community feedback on this issue. label Dec 29, 2024
@Machine-Maker Machine-Maker changed the title beginning of checkstyle configuration for API checkstyle configuration for API Dec 29, 2024
@Machine-Maker
Copy link
Member Author

Machine-Maker commented Dec 29, 2024

Ok, this is ready to be reviewed. I'm sure there will be things we notice when we start updating all the files it tells us to that we don't want, but we can make those changes as we go along.

This also isn't validated against any formatter yet, so there could be conflicts. We will find those out though as we go.

It also isn't running the custom import order yet, because that will come with the formatter.

@Machine-Maker Machine-Maker marked this pull request as ready for review December 29, 2024 21:44
@Machine-Maker Machine-Maker requested a review from a team as a code owner December 29, 2024 21:44
@Machine-Maker Machine-Maker force-pushed the chore/checkstyle branch 2 times, most recently from 10c4bb0 to e015bb8 Compare December 29, 2024 23:38
@Machine-Maker
Copy link
Member Author

So there's a ton of new logic now in the api's build.gradle. This should probably be moved somewhere, idk if we wanna do the buildSrc thing, or make it part of pw, or what

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: input wanted Looking for community feedback on this issue.
Projects
Status: Awaiting review
Development

Successfully merging this pull request may close these issues.

1 participant