Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix MapCanvas#drawImage #11865

Merged
merged 3 commits into from
Jan 7, 2025
Merged

Conversation

Warriorrrr
Copy link
Member

@Warriorrrr Warriorrrr commented Dec 29, 2024

Closes #11856, closes #11880

Fixes issues where changed pixels weren't being marked as changed (and thus not being updated), and fixes drawing images with < 128 width.


Download the paperclip jar for this pull request: paper-11865.zip

@Warriorrrr Warriorrrr requested a review from a team as a code owner December 29, 2024 15:21
@Folas1337

This comment was marked as spam.

@NoahvdAa NoahvdAa added the type: bug Something doesn't work as it was intended to. label Dec 30, 2024
@Malfrador Malfrador added the build-pr-jar Enables a workflow to build Paperclip jars on the pull request. label Jan 1, 2025
@Warriorrrr Warriorrrr changed the title Fix MapCanvas#drawImage not marking pixels as dirty Fix MapCanvas#drawImage Jan 2, 2025
@kennytv kennytv added the priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. label Jan 4, 2025
@lynxplay lynxplay force-pushed the fix/mapcanvas-draw-image branch from d2d0f87 to ebf0dd7 Compare January 4, 2025 22:32
@lynxplay lynxplay merged commit 3375570 into PaperMC:main Jan 7, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build-pr-jar Enables a workflow to build Paperclip jars on the pull request. priority: high This issue is either a gamebreaking bug or crash and needs to be addressed soon. type: bug Something doesn't work as it was intended to.
Projects
Status: Merged
Development

Successfully merging this pull request may close these issues.

MapCanvas#drawImage incorrectly renders images Map updates are ignored after the first call to render()
7 participants