[ci skip] Add @throws to BlockData#createBlockState JavaDoc #11888
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is not a proper fix, that error should not happen altogether so the underlying issue causing this should be fixed instead |
|
Agreed with @emilyy-dev . The underlying issue should be fixed so the exception is not thrown at all. It can be avoided in this case. First to fix the swallowed exception and to fix the issue with moving piston. If you'd like to work on that, feel free to open another pr. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Properly indicate in the JavaDoc that the method can throw an IllegalStateException if a block requires to be placed to get a BlockState for it (Currently only occurs for MOVING_PISTON).
Addresses #11887