Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CustomTimingsHandler Nag Message #11923

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

spring-dependency-management

No point telling them to switch to timings.of since timings will be removed soon

@spring-dependency-management spring-dependency-management requested a review from a team as a code owner January 6, 2025 03:16
@spring-dependency-management spring-dependency-management changed the title Tupdate customtimingshandler nag Update CustomTimingsHandler Nag Message Jan 6, 2025
@Doc94
Copy link
Contributor

Doc94 commented Jan 6, 2025

Maybe can be good mention spark here and maybe an alternative for what this class is used (?

lynxplay
lynxplay previously approved these changes Jan 6, 2025
@lynxplay lynxplay added the type: feature Request for a new Feature. label Jan 6, 2025
Copy link
Contributor

@lynxplay lynxplay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Timings is already removed, only the API types are left as NO-OP.
Probably good to mention that in this message.

Regarding spark, I am not aware of anything similar spark offers, not that there is much of a point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: feature Request for a new Feature.
Projects
Status: Changes required
Development

Successfully merging this pull request may close these issues.

3 participants