Expand PlayerItemMendEvent #7382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gersomonline
approved these changes
Jan 21, 2022
NoahvdAa
reviewed
Jan 21, 2022
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
from
ac39622 to
b504a5c
Compare
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
from
b504a5c to
9b5efaf
Compare
|
Rebased for 1.18.2 Now resolves 2 open issues. |
|
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Now resolves 3 open issues. |
kennytv
approved these changes
Jun 3, 2022
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
2 times, most recently
from
5cd7615 to
97a78c4
Compare
|
Ok, tested and this fixes the recursion issue, and the new API works as expected. I'll wait for a 2nd approval since this is new API and not a simple fix. |
|
Any updates on this PR? It seems to be fully implemented and functional already - is there anything that is blocking this from moving forward? |
kennytv
approved these changes
Aug 23, 2022
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
from
97a78c4 to
49a0fbc
Compare
This was referenced May 31, 2023
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
2 times, most recently
from
39ee9e6 to
a2e44e2
Compare
Machine-Maker
force-pushed
the
feature/expand-PlayerItemMendEvent
branch
from
a2e44e2 to
2da9441
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #7313
Resolves #7449
Closes #7815
Adds a getter/setter for the operation used to turn the amount of durability repaired, into an XP value to be subtracted away from the total value of the experience orb.