-
-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add StructuresLocateEvent as replacement for StructureLocateEvent #7524
Merged
kennytv
merged 14 commits into
PaperMC:dev/1.18.2
from
Machine-Maker:dev/1.18.2-StructuresLocateEvent
Mar 4, 2022
Merged
Add StructuresLocateEvent as replacement for StructureLocateEvent #7524
kennytv
merged 14 commits into
PaperMC:dev/1.18.2
from
Machine-Maker:dev/1.18.2-StructuresLocateEvent
Mar 4, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kennytv
reviewed
Mar 2, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine other than missing docs
kennytv
reviewed
Mar 2, 2022
electronicboy
approved these changes
Mar 2, 2022
f13bc0c
to
e26c45d
Compare
kashike
reviewed
Mar 2, 2022
e0c934b
to
b4ac11f
Compare
jpenilla
requested changes
Mar 3, 2022
d358851
to
276c5f3
Compare
jpenilla
approved these changes
Mar 4, 2022
kennytv
approved these changes
Mar 4, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Probably going to be #7522 or this, I don't think we should try to keep both as that would just make things even more complex.